Uh oh!
There was an error while loading. Please reload this page.
[3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272) - #107358
Closed
miss-islington wants to merge 3 commits into
Closed
[3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272)#107358miss-islington wants to merge 3 commits into
miss-islington wants to merge 3 commits into
Conversation
…gh-107272) We tried this before with a dict and for all interned strings. That ran into problems due to interpreter isolation. However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning. Here we circle back to using a global cache, but only for statically allocated strings. We also use a more-basic _Py_hashtable_t for that global cache instead of a dict. Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter. Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter. (cherry picked from commit b72947a) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
This was referenced Jul 27, 2023
ericsnowcurrently
commented
Jul 27, 2023
Member
As noted elsewhere, I'm going to mull over whether or not this is worth it in 3.12. CC @Yhg1s |
Member
|
ericsnowcurrently
commented
Jul 28, 2023
Member
Having slept on it, I don't see this change as important enough to be worth backporting, particularly given the release manager's reservations. |
ericsnowcurrently
commented
Oct 4, 2023
Member
This may be needed to fix gh-110279. |
This was referenced Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tried this before with a dict and for all interned strings. That ran into problems due to interpreter isolation. However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning. Here we circle back to using a global cache, but only for statically allocated strings. We also use a more-basic _Py_hashtable_t for that global cache instead of a dict.
Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter. Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter.
(cherry picked from commit b72947a)
Co-authored-by: Eric Snow ericsnowcurrently@gmail.com