Uh oh!
There was an error while loading. Please reload this page.
gh-107091: Fix some uses of :const: role - #107379
Merged
Merged
Conversation
It is for references, not for literals.
serhiy-storchakaforce-pushed
the
docs-const-role
branch
from
July 28, 2023 08:26
106973f to
b97bfeaComparevstinner
approved these changes
Jul 28, 2023
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. The old usage of const looks suspicious and wrong. Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!
miss-islington
commented
Jul 28, 2023
Contributor
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
bedevere-bot
commented
Jul 28, 2023
GH-107384 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 28, 2023
It is for references, not for literals. (cherry picked from commit 0aa58fa) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot
commented
Jul 28, 2023
GH-107385 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 28, 2023
It is for references, not for literals. (cherry picked from commit 0aa58fa) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit
that referenced
this pull request
Jul 28, 2023
serhiy-storchaka
commented
Jul 28, 2023
MemberAuthor
Hold my beer. #107386 |
serhiy-storchaka added a commit
that referenced
this pull request
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is for references, not for literals.
📚 Documentation preview 📚: https://cpython-previews--107379.org.readthedocs.build/