Uh oh!
There was an error while loading. Please reload this page.
gh-107467: Restructure Argument Clinic command-line interface - #107469
Merged
Conversation
- Add and use CLIError exception for CLI usage errors - On CLI error, print to stderr instead of stdout - Put the entire CLI in main() - Rework ClinicExternalTest to call main() instead of using subprocesses
3 tasks
erlend-aasland
commented
Jul 31, 2023
ContributorAuthor
@AlexWaygood, are you fine with this? |
AlexWaygood
commented
Jul 31, 2023
Member
Haven't had a chance to look deeply yet, and would like to! :) |
AlexWaygood
commented
Aug 1, 2023
Member
I think some of this is reinventing the wheel a little bit, and can be simplified by making use of the |
AlexWaygood
approved these changes
Aug 1, 2023
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
LGTM! Feel free to merge if you're happy with the changes I pushed :)
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
commented
Aug 1, 2023
ContributorAuthor
Thanks for the argparse error trick; I was unaware of that :) Let's land this and continue with the error handling refactoring. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.