Uh oh!
There was an error while loading. Please reload this page.
gh-106368: Increase test coverage for Argument Clinic - #107514
Conversation
erlend-aasland
commented
Jul 31, 2023
With this, we're pretty good covered (above 90%). AFAICS, converters, return converters, and most parser code has been tested. Most of what's missing is various error paths. I suggest we close the linked issue after landing this. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
AlexWaygood
left a comment
There was a problem hiding this comment.
The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)
erlend-aasland
commented
Aug 2, 2023
Thanks for the review; Nikita gave a thumbs up for the functional tests earlier, so I'll enable auto-merge 🚀 |
miss-islington
commented
Aug 2, 2023
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
commented
Aug 2, 2023
Sorry, @erlend-aasland, I could not cleanly backport this to |
miss-islington
commented
Aug 2, 2023
Sorry, @erlend-aasland, I could not cleanly backport this to |
picnixz
commented
Sep 14, 2024
3.11 and 3.12 never got their backports but I'm removing the labels (I'm going through PRs to see if we did not forgot a backport) (not sure if you want to backport this on 3.12) |
Uh oh!
There was an error while loading. Please reload this page.