Skip to content

GH-107458: fix test_tools refleak - #107577

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
kumaraditya303:refleak
Aug 3, 2023
Merged

GH-107458: fix test_tools refleak#107577
kumaraditya303 merged 2 commits into
python:mainfrom
kumaraditya303:refleak

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

@kumaraditya303

Copy link
Copy Markdown
ContributorAuthor

I have verified this locally, I'll merge as the buildbots are all already broken, will check later when things are better.

@kumaraditya303
kumaraditya303 enabled auto-merge (squash) August 3, 2023 05:55
@kumaraditya303
kumaraditya303 merged commit 46366ca into python:mainAug 3, 2023
@kumaraditya303
kumaraditya303 deleted the refleak branch August 3, 2023 14:14
@Eclips4

Copy link
Copy Markdown
Member

Are this really solve the issue?
this code still leaks:

importsysimportimportlibname="_decimal"importlib.import_module(name)
sys.modules.pop(name)
./python.exe-Xshowrefcountexample.py
[7624refs, 4253blocks]

@kumaraditya303

Copy link
Copy Markdown
ContributorAuthor

Nope, this fixes this test which was false leaking, you should try running the test_tools on current main branch.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303@Eclips4@bedevere-bot