Skip to content

gh-107614: Normalise Argument Clinic error messages - #107615

Merged
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:clinic/normalise-error-messages
Aug 4, 2023
Merged

gh-107614: Normalise Argument Clinic error messages#107615
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:clinic/normalise-error-messages

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Aug 4, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • always wrap the offending line, token, or name in quotes
  • always put the entire error message on one line

@erlend-aasland
pythongh-107614: Normalise Argument Clinic error messages
c66a492
- always wrap the offending line, token, or name in quotes
- always put the entire error message on one line
@bedevere-botbedevere-bot mentioned this pull request Aug 4, 2023
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Aug 4, 2023
Merged
@erlend-aasland

erlend-aasland commented Aug 4, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Depends on gh-107611 (or the other way around; either way, we'll have conflicts)

erlend-aasland
erlend-aasland commented Aug 4, 2023
View reviewed changes
Comment threadLib/test/test_clinic.py
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment threadLib/test/test_clinic.py
Comment threadLib/test/test_clinic.py
Comment threadLib/test/test_clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to keep line lengths below 90, where reasonable:

Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
@erlend-aasland@AlexWaygood
Apply suggestions from code review
015dea8
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland

erlend-aasland commented Aug 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Some suggestions to keep line lengths below 90, where reasonable:

Thanks; applied!

AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment threadLib/test/test_clinic.py
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
AlexWaygood
AlexWaygood approved these changes Aug 4, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
erlend-aaslandand others added 2 commits August 4, 2023 13:23
@erlend-aasland@AlexWaygood
Final touch
d681648
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland
Add test for dest clear
882fe9d
AlexWaygood
AlexWaygood approved these changes Aug 4, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@erlend-aasland

erlend-aasland commented Aug 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Looks great, thank you!

Thanks for the helpful review and suggestions!

@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 4, 2023 11:33
@erlend-aasland
erlend-aasland merged commit ac7605e into python:mainAug 4, 2023
@erlend-aasland
erlend-aasland deleted the clinic/normalise-error-messages branch August 4, 2023 12:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland@AlexWaygood@bedevere-bot