Skip to content

gh-104683: Argument Clinic: refactor format_docstring() - #107623

Merged
erlend-aasland merged 9 commits into
python:mainfrom
erlend-aasland:clinic/refactor-format-docstring
Aug 8, 2023
Merged

gh-104683: Argument Clinic: refactor format_docstring()#107623
erlend-aasland merged 9 commits into
python:mainfrom
erlend-aasland:clinic/refactor-format-docstring

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Aug 4, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Extract helper methods for formatting the signature and parameter
sections, and clean up the remaining function body.

@erlend-aasland
pythongh-104683: Argument Clinic: refactor format_docstring()
fd632eb
Extract helper methods for formatting the signature and parameter
sections, and clean up the remaining function body.
@bedevere-botbedevere-bot mentioned this pull request Aug 4, 2023
Closed
7 tasks
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
@erlend-aasland@AlexWaygood
Use splitlines() iso. comprehension
1d244dc
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood

AlexWaygood commented Aug 4, 2023

Copy link
Copy Markdown
Member

Looks like there's a bug somewhere -- CI is failing

@erlend-aasland

erlend-aasland commented Aug 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Looks like there's a bug somewhere -- CI is failing

Yes, splitlines() is not quite the same as the old comprehension :(

@erlend-aasland

erlend-aasland commented Aug 4, 2023

Copy link
Copy Markdown
ContributorAuthor

I reverted the splitlines change.

AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
@erlend-aasland@AlexWaygood
Split, not splitlines
0902130
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aaslanderlend-aasland mentioned this pull request Aug 4, 2023
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Aug 7, 2023
Merged
AA-Turner
AA-Turner reviewed Aug 8, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
erlend-aaslandand others added 3 commits August 8, 2023 08:52
@erlend-aasland@AA-Turner
Style
e3ff673
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@erlend-aasland
Merge branch 'main' into clinic/refactor-format-docstring
e041288
@erlend-aasland
Fix mypy
34729c2
AA-Turner
AA-Turner approved these changes Aug 8, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 8, 2023 20:43
@erlend-aasland

erlend-aasland commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews, Adam and Alex!

@erlend-aasland
erlend-aasland merged commit 7350738 into python:mainAug 8, 2023
@erlend-aasland
erlend-aasland deleted the clinic/refactor-format-docstring branch August 8, 2023 21:18
@erlend-aasland

erlend-aasland commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

That's strange; automerge continued through even though the Windows (x86) CI failed (apparently it failed then succeeded because some of the flakey tests were flakey).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@AA-TurnerAA-TurnerAA-Turner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@AlexWaygood@AA-Turner@bedevere-bot