Skip to content

GH-100425: Note improved commutativity in sum(). - #107785

Merged
rhettinger merged 1 commit into
python:mainfrom
rhettinger:sum_algo
Aug 8, 2023
Merged

GH-100425: Note improved commutativity in sum().#107785
rhettinger merged 1 commit into
python:mainfrom
rhettinger:sum_algo

Conversation

@rhettinger

@rhettingerrhettinger commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

@rhettinger

Copy link
Copy Markdown
ContributorAuthor

Script to demonstrate the improvement:

from random import random
from itertools import permutations
n = 4
trials = 100
errors = 0
for i in range(trials):
example = [random() for i in range(n)]
if len(set(map(sum, permutations(example)))) != 1:
errors += 1
print(i, sorted(example))
print(f'{errors / trials * 100.0=}%')

Formerly there was a 63% error rate. Now it is zero.

@rhettinger
rhettinger merged commit aab6f71 into python:mainAug 8, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-107787 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Aug 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2023
(cherry picked from commit aab6f71)
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rhettinger@miss-islington@bedevere-bot