Skip to content

gh-95065: Produce nicer deprecation messages in Argument Clinic - #107808

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:clinic/nicer-deprecation-messages
Aug 9, 2023
Merged

gh-95065: Produce nicer deprecation messages in Argument Clinic#107808
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:clinic/nicer-deprecation-messages

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Aug 9, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Aug 9, 2023
Closed
@erlend-aasland

erlend-aasland commented Aug 9, 2023

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka: this will probably cause merge conflicts with your work on deprecating keyword arguments.

@erlend-aasland

erlend-aasland commented Aug 9, 2023

Copy link
Copy Markdown
ContributorAuthor

(the Azure failure is unrelated; flakey test_concurrent_futures test)

serhiy-storchaka
serhiy-storchaka reviewed Aug 9, 2023
View reviewed changes
Comment threadLib/test/clinic.test.c Outdated
@serhiy-storchaka

serhiy-storchaka commented Aug 9, 2023

Copy link
Copy Markdown
Member

Thank you. Nice change.

@erlend-aasland

erlend-aasland commented Aug 9, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, Serhiy; highly appreciated.

@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 9, 2023 13:00
@erlend-aaslanderlend-aasland mentioned this pull request Aug 9, 2023
Merged
AlexWaygood
AlexWaygood approved these changes Aug 9, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice indeed!

@erlend-aasland
erlend-aasland merged commit 0a7f48b into python:mainAug 9, 2023
@erlend-aasland
erlend-aasland deleted the clinic/nicer-deprecation-messages branch August 9, 2023 13:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@serhiy-storchaka@AlexWaygood@bedevere-bot