Skip to content

gh-107298: Fix C API datetime documentation - #108034

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:docs-capi-datetime
Aug 21, 2023
Merged

gh-107298: Fix C API datetime documentation#108034
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:docs-capi-datetime

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Aug 16, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchakaserhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 16, 2023
@bedevere-botbedevere-bot mentioned this pull request Aug 16, 2023
Closed
vstinner
vstinner reviewed Aug 21, 2023
View reviewed changes
Comment threadDoc/c-api/datetime.rst
Comment threadDoc/c-api/datetime.rst Outdated
vstinner
vstinner approved these changes Aug 21, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to ignore my remarks (or address them in a separated PR).

@serhiy-storchaka
serhiy-storchaka merged commit d63972e into python:mainAug 21, 2023
@serhiy-storchaka
serhiy-storchaka deleted the docs-capi-datetime branch August 21, 2023 18:15
@miss-islington

miss-islington commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

There's a new commit after the PR has been approved.

@vstinner: please review the changes made to this pull request.

@miss-islington

miss-islington commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d63972e289e05b0d82e59f32f107312a8b3de7b5 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@serhiy-storchaka@miss-islington
pythongh-107298: Fix C API datetime documentation (pythonGH-108034)
bf6afa1
(cherry picked from commit d63972e)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

GH-108233 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Aug 21, 2023
@serhiy-storchaka

serhiy-storchaka commented Aug 21, 2023

Copy link
Copy Markdown
MemberAuthor

Thank you for your review @vstinner.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 21, 2023
@serhiy-storchaka
[3.12]pythongh-107298: Fix C API datetime documentation (pythonGH-10…
a14f0a1
…8034).
(cherry picked from commit d63972e)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

GH-108234 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Aug 21, 2023
Yhg1s pushed a commit that referenced this pull request Aug 21, 2023
@serhiy-storchaka
[3.12]gh-107298: Fix C API datetime documentation (GH-108034). (#108234
47f60c3
)
(cherry picked from commit d63972e)
ambv pushed a commit that referenced this pull request Aug 22, 2023
@miss-islington@serhiy-storchaka
[3.11]gh-107298: Fix C API datetime documentation (GH-108034) (#108233)
80c7ae0
(cherry picked from commit d63972e)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchakaserhiy-storchaka removed their assignment Sep 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner
@abalkinabalkinAwaiting requested review from abalkin
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting core reviewdocsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@miss-islington@bedevere-bot@vstinner