Uh oh!
There was an error while loading. Please reload this page.
gh-95065, gh-107704: Argument Clinic: support multiple '/ [from ...]' and '* [from ...]' markers - #108132
Conversation
… [from ...]' and '* [from ...]' markers
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
commented
Aug 21, 2023
Indeed, the refactors from your previous PR came in handy here. |
erlend-aasland
commented
Aug 21, 2023
Thanks, this is nice; @AlexWaygood, are you fine with this feature? |
There was a problem hiding this comment.
This looks pretty good to me! I'm impressed how little extra code it takes. I have one readability style nit.
I think we should maybe also add one or two examples to https://docs.python.org/3.13/howto/clinic.html#how-to-deprecate-passing-parameters-positionally-or-by-keyword that have mutliple / [from ...] and * [from ...] markers
Uh oh!
There was an error while loading. Please reload this page.
It does not even make the code much more complex. Simply the code which checks that the version is the same is replaced with the code which supports multiple versions.