Uh oh!
There was an error while loading. Please reload this page.
Run sphinx-lint on Misc/NEWS.d/next/ - #108212
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM.
Although I do not see a difference in some files. Why are they marked as different?
hugovk
commented
Aug 21, 2023
They were "No newline at end of file": https://github.com/hugovk/cpython/actions/runs/5925848833/job/16066091943 |
hugovk
commented
Aug 21, 2023
The 3.12 backport will only need the first commit, I'll backport it manually. |
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks good, a few optional suggestions:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot
commented
Aug 21, 2023
GH-108213 is a backport of this pull request to the 3.12 branch. |
bedevere-bot
commented
Aug 21, 2023
There's a new commit after the PR has been approved. @serhiy-storchaka, @AlexWaygood: please review the changes made to this pull request. |
…issue-105736.NJsH7r.rst (effectively a backport of pythonGH-108212).
Fix lint warnings in Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst (effectively a backport of GH-108212).
Follow on from #105750.
Before that PR, we used to run sphinx-lint on
Doc/andMisc/NEWS.d/next/After, we only ran sphinx-lint on
Doc/. I think leaving outMisc/NEWS.d/next/was an oversight on my part, let's add it back.In the meantime, a handful of NEWS warnings had slipped through, this PR also fixes them.