Skip to content

gh-106016: Add Lib/test/test_module/ directory - #108293

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_module
Aug 22, 2023
Merged

gh-106016: Add Lib/test/test_module/ directory#108293
vstinner merged 1 commit into
python:mainfrom
vstinner:test_module

Conversation

@vstinner

@vstinnervstinner commented Aug 22, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • Move Python scripts related to test_module to this new directory: good_getattr.py and bad_getattrX.py scripts.
  • Move Lib/test/test_module.py to Lib/test/test_module/init.py.

@vstinner
pythongh-106016: Add Lib/test/test_module/ directory
d05842b
* Move Python scripts related to test_module to this new directory:
good_getattr.py and bad_getattrX.py scripts.
* Move Lib/test/test_module.py to Lib/test/test_module/__init__.py.
@bedevere-botbedevere-bot mentioned this pull request Aug 22, 2023
Closed
This was referenced Aug 22, 2023
Closed
Closed
@vstinner
vstinner merged commit adfc118 into python:mainAug 22, 2023
@miss-islington

miss-islington commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@vstinner
vstinner deleted the test_module branch August 22, 2023 14:53
@miss-islington

miss-islington commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker adfc118fdab66882599e01a84c22bd897055f3f1 3.12

@bedevere-bot

bedevere-bot commented Aug 22, 2023

Copy link
Copy Markdown

GH-108304 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2023
@vstinner@miss-islington
pythongh-106016: Add Lib/test/test_module/ directory (pythonGH-108293)
b424f10
* Move Python scripts related to test_module to this new directory:
good_getattr.py and bad_getattrX.py scripts.
* Move Lib/test/test_module.py to Lib/test/test_module/__init__.py.
(cherry picked from commit adfc118)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Aug 22, 2023
@vstinnervstinner added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Aug 22, 2023
@miss-islington

miss-islington commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Sorry @vstinner, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker adfc118fdab66882599e01a84c22bd897055f3f1 3.12

@bedevere-bot

bedevere-bot commented Aug 22, 2023

Copy link
Copy Markdown

GH-108306 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Aug 22, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Aug 22, 2023
@vstinner
pythongh-106016: Add Lib/test/test_module/ directory (python#108293)
687734e
* Move Python scripts related to test_module to this new directory:
good_getattr.py and bad_getattrX.py scripts.
* Move Lib/test/test_module.py to Lib/test/test_module/__init__.py.
(cherry picked from commit adfc118)
vstinner added a commit that referenced this pull request Aug 22, 2023
@miss-islington@vstinner
[3.11]gh-106016: Add Lib/test/test_module/ directory (GH-108293) (#1…
5be32d8
…08304)
gh-106016: Add Lib/test/test_module/ directory (GH-108293)
* Move Python scripts related to test_module to this new directory:
good_getattr.py and bad_getattrX.py scripts.
* Move Lib/test/test_module.py to Lib/test/test_module/__init__.py.
(cherry picked from commit adfc118)
Co-authored-by: Victor Stinner <vstinner@python.org>
Yhg1s pushed a commit that referenced this pull request Aug 22, 2023
@vstinner
[3.12]gh-106016: Add Lib/test/test_module/ directory (#108293) (#108306
ca47a21
)
gh-106016: Add Lib/test/test_module/ directory (#108293)
* Move Python scripts related to test_module to this new directory:
good_getattr.py and bad_getattrX.py scripts.
* Move Lib/test/test_module.py to Lib/test/test_module/__init__.py.
(cherry picked from commit adfc118)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vstinnervstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@miss-islington@bedevere-bot