Skip to content

gh-107902: Don't test setting suid/sgid on systems that don't support them - #108368

Merged
encukou merged 2 commits into
python:mainfrom
encukou:gh-107902
Sep 4, 2023
Merged

gh-107902: Don't test setting suid/sgid on systems that don't support them#108368
encukou merged 2 commits into
python:mainfrom
encukou:gh-107902

Conversation

@encukou

@encukouencukou commented Aug 23, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request Aug 12, 2023
Closed
2 tasks
@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 23, 2023
@encukou

encukou commented Aug 23, 2023

Copy link
Copy Markdown
MemberAuthor

@furkanonder, could you check this on the Manjaro aarch64 system?

ethanfurman
ethanfurman reviewed Aug 23, 2023
View reviewed changes
Comment threadLib/test/test_tarfile.py
@furkanonder

furkanonder commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

@furkanonder, could you check this on the Manjaro aarch64 system?

It looks good to me, the tests are not failing anymore.

[ted@rasp4 cpython]$ ./python -m test test_tarfile
0:00:00 load avg: 1.04 Run tests sequentially
0:00:00 load avg: 1.04 [1/1] test_tarfile
test_tarfile passed in 2 min 29 sec
== Tests result: SUCCESS ==
1 test OK.
Total duration: 2 min 29 sec
Tests result: SUCCESS
[ted@rasp4 cpython]$

@encukou
encukou merged commit 40e52c9 into python:mainSep 4, 2023
@encukou
encukou deleted the gh-107902 branch September 4, 2023 13:46
encukou added a commit to encukou/cpython that referenced this pull request Oct 10, 2024
@encukou
pythongh-107902: Don't test setting suid/sgid on systems that don't s…
e3ecd5b
…upport them (pythonGH-108368)
@encukouencukou mentioned this pull request Oct 10, 2024
Merged
encukou added a commit to encukou/cpython that referenced this pull request Oct 16, 2024
@encukou
pythongh-107902: Don't test setting suid/sgid on systems that don't s…
5a5b9b9
…upport them (pythonGH-108368)
@encukouencukou mentioned this pull request Oct 16, 2024
Merged
pablogsal pushed a commit that referenced this pull request Oct 22, 2024
@encukou@vstinner
[3.10]gh-107902:gh-108948: Don't test setting suid/sgid/sticky on s…
6bbaab8
…ystems that don't support them (GH-108368) (GH-109697) (#125255)
* gh-107902: Don't test setting suid/sgid on systems that don't support them (GH-108368)
* gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697)
On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.
---------
Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2024
@encukou@vstinner@miss-islington
[3.10]pythongh-107902:pythongh-108948: Don't test setting suid/sgid…
3c00a44
…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255)
* pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368)
* pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697)
On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.
---------
(cherry picked from commit 6bbaab8)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islingtonmiss-islington mentioned this pull request Oct 22, 2024
Closed
ambv pushed a commit that referenced this pull request Oct 28, 2024
@encukou@vstinner
[3.9]gh-107902:gh-108948: Don't test setting suid/sgid/sticky on sy…
eb16397
…stems that don't support them (GH-108368) (GH-109697) (#125576)
On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurmanethanfurmanethanfurman left review comments
@furkanonderfurkanonderfurkanonder approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou@furkanonder@ethanfurman@bedevere-bot