Skip to content

gh-108308: Replace _PyDict_GetItemStringWithError() - #108372

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:dict_getref2
Aug 23, 2023
Merged

gh-108308: Replace _PyDict_GetItemStringWithError()#108372
vstinner merged 1 commit into
python:mainfrom
vstinner:dict_getref2

Conversation

@vstinner

@vstinnervstinner commented Aug 23, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Replace _PyDict_GetItemStringWithError() calls with PyDict_GetItemStringRef() which returns a strong reference to the item.

@bedevere-botbedevere-bot mentioned this pull request Aug 23, 2023
Closed
2 tasks
serhiy-storchaka
serhiy-storchaka reviewed Aug 23, 2023
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

Comment threadObjects/structseq.c Outdated
Comment threadPython/pylifecycle.c
Comment threadPython/pylifecycle.c
Comment threadPython/pylifecycle.c Outdated
Comment threadPython/pylifecycle.c
@vstinner@serhiy-storchaka
pythongh-108308: Replace _PyDict_GetItemStringWithError()
a1192ad
Replace _PyDict_GetItemStringWithError() calls with
PyDict_GetItemStringRef() which returns a strong reference to the
item.
Co-Authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner

vstinner commented Aug 23, 2023

Copy link
Copy Markdown
MemberAuthor

@serhiy-storchaka: I integrated your suggested changes and made you as a co-author. I addressed your review. Would you mind to review the updated PR?

@vstinner
vstinner merged commit 4dc9f48 into python:mainAug 23, 2023
@vstinner
vstinner deleted the dict_getref2 branch August 23, 2023 20:59
@serhiy-storchaka

serhiy-storchaka commented Aug 23, 2023

Copy link
Copy Markdown
Member

@serhiy-storchaka: I integrated your suggested changes and made you as a co-author.

Oh, it was minor comment. I like how this API allows to write the code in multiple ways, to better fit in every particular case.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@serhiy-storchaka@bedevere-bot