Uh oh!
There was an error while loading. Please reload this page.
gh-107901: add the HAS_EVAL_BREAK instruction flag - #108375
Conversation
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum
left a comment
There was a problem hiding this comment.
I like how the flags framework is so easily extensible.
| return [n for n, v in dataclasses.asdict(self).items() if v == value] | ||
| def bitmap(self) -> int: | ||
| def bitmap(self, ignore: list[str] = []) -> int: |
There was a problem hiding this comment.
Using a mutable default sets alarm bells off in my head, even though you're safe in this case. Maybe make it an abstract set?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
bedevere-bot
commented
Aug 25, 2023
|
bedevere-bot
commented
Aug 25, 2023
|
This is motivated by #107901, which implies we need to make sure that all instructions the have an eval breaker check also have a line number.
I'm not adding that assertion here because it will fail, so that's going to require more work.