Uh oh!
There was an error while loading. Please reload this page.
gh-108455: Run mypy on Tools/peg_generator - #108456
Conversation
hugovk
commented
Aug 25, 2023
(Resolved conflict) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| issoftkeyword = frozenset(softkwlist).__contains__ | ||
| '''.lstrip() | ||
There was a problem hiding this comment.
LGTM, though I'm slightly unclear on whether this code is upstream to or vendored from https://github.com/we-like-parsers/pegen
Uh oh!
There was an error while loading. Please reload this page.
pablogsal
commented
Aug 25, 2023
The other way around: that code is adapted from the one in CPython. |
AlexWaygood
commented
Aug 28, 2023
@pablogsal, would you find it helpful to have mypy run on this code in CI at CPython? I'm not generally involved in maintaining |
pablogsal
commented
Aug 28, 2023
I think that would be very helpful, indeed, as these types should be up to date 👍 |
pablogsal
commented
Aug 28, 2023
Thanks a lot for the PR @sobolevn and thanks for the review @AlexWaygood |
bedevere-bot
commented
Aug 28, 2023
|
Notes:
type: ignore[import]will be removed aftertypes-setuptoolsis installedIncompletewill be removed as wellmypyonTools/peg_generator#108455