Skip to content

gh-108364: Simplify quoting values and identifiers in sqlite3's iterdump() - #108472

Merged
erlend-aasland merged 3 commits into
python:mainfrom
felixxm:sqlite-dump-readable
Aug 25, 2023
Merged

gh-108364: Simplify quoting values and identifiers in sqlite3's iterdump()#108472
erlend-aasland merged 3 commits into
python:mainfrom
felixxm:sqlite-dump-readable

Conversation

@felixxm

@felixxmfelixxm commented Aug 25, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@felixxmfelixxm mentioned this pull request Aug 25, 2023
Merged
felixxm
felixxm commented Aug 25, 2023
View reviewed changes
Comment threadLib/sqlite3/dump.py Outdated
@erlend-aasland

erlend-aasland commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

This is a nice cleanup. I think we should add this as a separate PR, instead of as a part of #108340.

@erlend-aaslanderlend-aasland changed the title Simplify quoting values/identifiers in sqlite3.dump._iter dump().gh-108364: Simplify quoting values and identifiers in sqlite3's iterdump()Aug 25, 2023
@bedevere-botbedevere-bot mentioned this pull request Aug 25, 2023
Closed
@felixxm
felixxmforce-pushed the sqlite-dump-readable branch from 333c0f5 to 2423154CompareAugust 25, 2023 09:42
@felixxm

felixxm commented Aug 25, 2023

Copy link
Copy Markdown
ContributorAuthor

This is a nice cleanup. I think we should add this as a separate PR, instead of as a part of #108340.

Agreed. #108340 could use new hooks so I would merge this PR first.

@erlend-aasland

erlend-aasland commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Agreed. #108340 could use new hooks so I would merge this PR first.

Sounds good to me.

@erlend-aasland

erlend-aasland commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Seems main was recently broken by #107988; we'll have to wait for that issue to be resolved before landing.

@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 25, 2023 12:05
@erlend-aasland
erlend-aasland merged commit 75903f2 into python:mainAug 25, 2023
@felixxm
felixxm deleted the sqlite-dump-readable branch August 25, 2023 19:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixxm@erlend-aasland@bedevere-bot