Skip to content

gh-108494: AC supports pos-only args in limited C API - #108498

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:ac_pos_limited
Aug 25, 2023
Merged

gh-108494: AC supports pos-only args in limited C API#108498
vstinner merged 1 commit into
python:mainfrom
vstinner:ac_pos_limited

Conversation

@vstinner

@vstinnervstinner commented Aug 25, 2023

Copy link
Copy Markdown
Member

AC now checks for "#define Py_LIMITED_API" pattern to use the limited C API.

AC now checks for "#define Py_LIMITED_API" pattern to use the limited
C API.
@vstinner
vstinner merged commit 86bc9e3 into python:mainAug 25, 2023
@vstinner
vstinner deleted the ac_pos_limited branch August 25, 2023 22:39
{parse_arguments}))
goto exit;
""", indent=4)]
argname_fmt = 'args[%d]'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not correct. In best case it is unused.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since AC and parsing arguments are complex, I propose to implement incrementally the limited C API. I'm not sure that I get your comment, when is it unused? Do you want to propose a fix?

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner, would you be able to add some documentation for this change to https://docs.python.org/3/howto/clinic.html? It would be useful information for users of Argument Clinic to know that they can generate code that only uses the limited C API by adding #define Py_LIMITED_API to a file

@vstinner

Copy link
Copy Markdown
MemberAuthor

@vstinner, would you be able to add some documentation for this change to https://docs.python.org/3/howto/clinic.html? It would be useful information for users of Argument Clinic to know that they can generate code that only uses the limited C API by adding #define Py_LIMITED_API to a file

I wrote PR #108584 to document the Limited C API feature.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@serhiy-storchaka@AlexWaygood@bedevere-bot