Uh oh!
There was an error while loading. Please reload this page.
gh-108494: Argument Clinic: fix support of Limited C API - #108536
Conversation
952e38c to
1896045Compareserhiy-storchaka
commented
Aug 27, 2023
Yet one issue: the |
| def test_varargs1min(self): | ||
| msg = r"get expected at least 1 argument, got 0" | ||
| msg = (r"get\(\) takes at least 1 argument \(0 given\)|" |
There was a problem hiding this comment.
PyArg_ParseTuple() produces slightly different error message.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Aug 27, 2023
I'm very excited by this change! I will try to review it soon. Would it be possible to write unit tests in _testclinic_limited and test_clinic, for unusual cases like deprecated parameters and (if possible) defining class? In my other PR, I wrote tests for basic positional or keywords parameters. |
serhiy-storchaka
commented
Aug 27, 2023
As for tests, I think that we should run all (or almost all) clinic tests in two modes. Instead of adding new tests for the limited API or duplicating test code we should generate and build different modules from the same source with different options. But this is a different PR. |
| arg = PyLong_AsInt(arg_); | ||
| if (arg == -1 && PyErr_Occurred()) { | ||
| if (!PyArg_Parse(arg_, "i:my_int_func", &arg)) { |
There was a problem hiding this comment.
It looks like regression, but actually not all inlined parsing code is compatible with the limited C API. In following PR I will implement inlining correctly, only for converters compatible with the limited C API. It will be large but mostly boring change (adding new parameter and simple checks in tens of functions), so I did not include it here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
left a comment
There was a problem hiding this comment.
I may have missed something, but this looks good to me. Thanks, Serhiy!
AlexWaygood
left a comment
There was a problem hiding this comment.
No complaints from me (though I'm not an expert on the limited C API)
I tried to enable the use of the limited C API in Argument Clinic for all code. With this PR it generates working code, and all tests are passed, except the low-level vectorcall test in
test_calland few tests intest_clinic(as expected)._struct.candwinreg.cuse converters incompatible with the limited C API. I temporary blacklisted these files. I only tested on Linux, so there may be errors in Windows or macOS specific modules.