Skip to content

GH-107603: Clinic: Pass specific attributes to print_block() - #108581

Merged
AlexWaygood merged 5 commits into
python:mainfrom
AA-Turner:clinic-includes
Aug 28, 2023
Merged

GH-107603: Clinic: Pass specific attributes to print_block()#108581
AlexWaygood merged 5 commits into
python:mainfrom
AA-Turner:clinic-includes

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Aug 28, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request Aug 28, 2023
Closed
@AA-TurnerAA-Turner mentioned this pull request Aug 28, 2023
Merged
@AA-Turner

AA-Turner commented Aug 28, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

mypy failure seems unrelated: (Edit: very related!)

erlend-aasland
erlend-aasland reviewed Aug 28, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py
@AA-TurnerAA-Turner changed the title GH-107603: Clinic: Only pass includes to print_block()GH-107603: Clinic: Pass specific attributes to print_block()Aug 28, 2023
AlexWaygood
AlexWaygood reviewed Aug 28, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
vstinner
vstinner approved these changes Aug 28, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlexWaygood
AlexWaygood approved these changes Aug 28, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AA-Turner

AA-Turner commented Aug 28, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks all for the (incredibly fast) reviews!

A

@AlexWaygood

AlexWaygood commented Aug 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Oh, looks like you'll need to slightly rework two unit tests in test_clinic.py to get CI passing

@AlexWaygood
AlexWaygood enabled auto-merge (squash) August 28, 2023 20:39
@AlexWaygood
AlexWaygood merged commit 0bd2ba5 into python:mainAug 28, 2023
@bedevere-bot

This comment was marked as abuse.

Sign in to view
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting core reviewskip newstopic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner@AlexWaygood@bedevere-bot@vstinner@erlend-aasland