Uh oh!
There was an error while loading. Please reload this page.
GH-108614: Add RESUME_CHECK instruction - #108630
Merged
Merged
Conversation
…trumentation and signals in the tier 2 interpreter.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
RESUME_QUICK instructionRESUME_CHECK instructionbrandtbucher
self-requested a review
August 31, 2023 16:20
Uh oh!
There was an error while loading. Please reload this page.
hoodmane
reviewed
Sep 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
iritkatriel
approved these changes
Sep 7, 2023
brettcannon
commented
Sep 7, 2023
Member
I think this may have broken the Emscripten builds: |
vstinner
commented
Sep 10, 2023
Member
According to @iritkatriel bisect, this change introduced a regression: #109198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimizes overhead of checking for instrumentation and signals in the tier 2 interpreter, and reduces the need for
#if TIER_ONEspecial casing.TIER_ONEandTIER_TWOfrom bytecodes.c #108614