Uh oh!
There was an error while loading. Please reload this page.
clarify distinction between datetime module and class in deprecation messages (again) - #109080
Closed
neutrinoceros wants to merge 2 commits into
Closed
clarify distinction between datetime module and class in deprecation messages (again)#109080neutrinoceros wants to merge 2 commits into
neutrinoceros wants to merge 2 commits into
Conversation
ellert
commented
Sep 7, 2023
Line 1816.... |
neutrinocerosforce-pushed
the
consistent_datetime_depr_warnings
branch
from
September 7, 2023 13:35
59c4eb0 to
6f22f49Compareneutrinoceros
commented
Sep 7, 2023
ContributorAuthor
fixed, but next time please consider asking nicely. |
AA-Turner
approved these changes
Sep 8, 2023
neutrinoceros
commented
Oct 4, 2023
ContributorAuthor
ping @Yhg1s for merge ? |
neutrinoceros
commented
Feb 10, 2024
ContributorAuthor
I think I saw a thread on https://discuss.python.org/ at some point, discussing whether warning messages should be exactly preserved in between patch releases, however I wasn't able to find it back. Surely it would clarify if this PR is even wanted. |
neutrinoceros
commented
Feb 10, 2024
ContributorAuthor
Oh actually it's not just any conflict: my PR is completely superseded by #114761, so no reason to keep it around ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #108073, in response to @ellert's comment #108073 (comment)
I think this time we have all of them.