Uh oh!
There was an error while loading. Please reload this page.
gh-109054: Document configure variables - #109224
Conversation
9b3fc31 to
3485011Comparevstinner
commented
Sep 10, 2023
I'm not sure if adding a new dedicated I chose to use I used Initially, I just wrote this PR to document |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Sep 10, 2023
I reorganized the doc. I'm not sure between cc @hugovk |
vstinner
commented
Sep 10, 2023
@erlend-aasland: it seems like the whole "3.3.4. Libraries Options" section is new in Python 3.11, all xxx_CFLAGS and xxx_LIBS, no? |
vstinner
commented
Sep 10, 2023
PROFILE_TASK was added in Python 3.8. |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
commented
Sep 11, 2023
Yes, it came with the setup.py migration we did. |
| Name for machine-dependent library files. | ||
| Libraries Options |
There was a problem hiding this comment.
How about Third-party dependencies or Options for third-party dependencies?
There was a problem hiding this comment.
Go for "Options for third-party dependencies".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Sep 11, 2023
@erlend-aasland: I updated my PR, would you mind to review it again? |
| .. cmdoption:: LIBATOMIC | ||
| Linker flags when ``cpython/pyatomic.h`` header file is used. | ||
| Default: ``LIBATOMIC='-latomic'`` if ``libatomic`` is needed, or | ||
| ``LIBATOMIC=''`` otherwise (also the default when Python is cross-compiled). | ||
| .. versionadded:: 3.13 | ||
There was a problem hiding this comment.
This is going away with #109344:
| .. cmdoption:: LIBATOMIC | |
| Linker flags when ``cpython/pyatomic.h`` header file is used. | |
| Default: ``LIBATOMIC='-latomic'`` if ``libatomic`` is needed, or | |
| ``LIBATOMIC=''`` otherwise (also the default when Python is cross-compiled). | |
| .. versionadded:: 3.13 |
There was a problem hiding this comment.
I understand that you want me to remove this variable in the doc, so I removed it.
29756c5 to
dc0ebcdCompareOh sorry for the noise, I tried a Git tool which messed up with my PR. I fixed my PR. |
f0ce11d to
2796022Comparevstinner
commented
Sep 19, 2023
PR rebased on the main branch. |
ezio-melotti
left a comment
There was a problem hiding this comment.
I would keep the PR focused and handle capitalization issues in a separate PR.
New titles should follow the existing conventions, even if it doesn't match the preferred capitalization specified by the devguide. A follow-up PR can fix it.
Uh oh!
There was an error while loading. Please reload this page.
b5eda29 to
9780c71Comparevstinner
commented
Sep 19, 2023
Hum, ok, I reverted these changes. I didn't expect that changing a few titles would be so controversial :-) |
9780c71 to
4993499Compare4993499 to
8ce10b5CompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
vstinner
commented
Sep 19, 2023
@erlend-aasland@hugovk@ezio-melotti: I rebased my PR on the main branch, squashed commits, I reverted title casing change (don't use Titlecase Anymore). Please review the updated PR. @ezio-melotti: I applied your sugsestions to use |
hugovk
commented
Sep 19, 2023
Looks good, although I'll leave approval for someone who knows about these flags 👍 |
AA-Turner
left a comment
There was a problem hiding this comment.
Looks good Sphinx-wise. (But same caveat as Hugo wrt the flags)
A
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
vstinner
commented
Sep 20, 2023
Thanks for the reviews. If someone has more remarks, feel free to propose a PR :-) |
erlend-aasland
commented
Sep 21, 2023
LGTM! Thanks for documenting these things. |
📚 Documentation preview 📚: https://cpython-previews--109224.org.readthedocs.build/