gh-108996: fix and enable test_msvcrt by aisk · Pull Request #109226 · python/cpython

aisk · 2023-09-10T12:01:55Z

More details: #109004

Issue: Add tests for msvcrt module #108996

vstinner

I would prefer to start easy: reenable the whole file, but still skip tests known to fail, and then in a following PR, fix these tests. So we can spend more time to test in length the second PR.

vstinner · 2023-09-10T16:15:51Z

@@ -1,9 +1,8 @@
+import ctypes


ctypes is not always available. Please use try: import ctypes except ImportError: ctypes = None, and then skip tests using ctypes if ctypes is None.

vstinner · 2023-09-10T16:16:33Z

- sys.stdin = old_stdin
+ with open('CONIN$', 'rb', buffering=0) as stdin:
+ h = msvcrt.get_osfhandle(stdin.fileno())
+ ctypes.windll.kernel32.FlushConsoleInputBuffer(h)


Maybe it should be exposed in msvcrt, maybe as a private function just for testing.

aisk · 2023-09-10T16:31:48Z

@vstinner Current implementation doesn't failes in latest two runs, maybe it's been fixed. But the freebsd tests failed:

1 test failed again:
test_msvcrt

I think it's weird, the tests should not run on freebsd.

vstinner · 2023-09-10T18:05:34Z

I think it's weird, the tests should not run on freebsd.

The test failed because ctypes is not available on this FreeBSD CI:

ModuleNotFoundError: No module named '_ctypes'

I told you, in tests, you should tolerate that ctypes is not available.

Or write a wrapper to FlushConsoleInputBuffer() in msvcrt or in _testconsole module (PC/_testconsole.c).

aisk · 2023-09-11T09:31:12Z

@vstinner Ah sorry, just understood what you mean above...

aisk · 2023-09-11T12:39:22Z

This change passed the tests in the last three times, I think it's ready to review.

aisk · 2023-09-15T09:58:31Z

Latest run failed because of freebsd test instance out of limit, not related to this change.

zooba · 2023-09-21T15:36:04Z

I don't have any further feedback. @vstinner are you happy with this?

vstinner · 2023-09-21T19:48:43Z

!buildbot Windows

bedevere-bot · 2023-09-21T19:48:45Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit dfd3992 🤖

The command will test the builders whose names match following regular expression: Windows

The builders matched are:

vstinner · 2023-09-21T19:52:42Z

!buildbot AMD64 Windows

bedevere-bot · 2023-09-21T19:52:44Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit dfd3992 🤖

The command will test the builders whose names match following regular expression: AMD64 Windows

The builders matched are:

AMD64 Windows11 Refleaks PR
AMD64 Windows11 Non-Debug PR
AMD64 Windows10 PR
AMD64 Windows11 Bigmem PR

vstinner · 2023-09-21T19:54:07Z

@vstinner are you happy with this?

Let's see if buildbots are happy :-)

vstinner · 2023-09-22T00:17:13Z

Tests passed on these 4 Windows buildbots: good.

buildbot/AMD64 Windows11 Bigmem PR — Build done.
buildbot/AMD64 Windows11 Non-Debug PR — Build done.
buildbot/ARM64 Windows Non-Debug PR — Build done.
buildbot/ARM64 Windows PR — Build done.

Example on ARM64 Windows Non-Debug PR:

0:06:33 load avg: 0.13 [382/463/1] test_msvcrt passed

vstinner · 2023-09-22T00:21:15Z

Merged, thanks @aisk for your contribution. Let's see how it goes this time :-)

I'm not surprised that these tests failed. It's hard to write reliable tests on a terminal :-( Calling FlushConsoleInputBuffer() seems to make tests more reliable: good!

I enhanced/completed the commit message.

aisk · 2023-09-22T10:19:58Z

Thanks for the review!

* Add _testconsole.flush_console_input_buffer() function. * test_kbhit(), test_getwch() and test_getwche() now call flush_console_input_buffer(). * Don't override sys.stdin anymore (not needed).

pythongh-108996: fix and enable test_msvcrt
c8d3c3f

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 10, 2023

bedevere-bot mentioned this pull request Sep 8, 2023
Add tests for msvcrt module #108996
Closed

aisk mentioned this pull request Sep 10, 2023
gh-108996: add tests for msvcrt #109004
Merged

aiskand others added 4 commits September 10, 2023 21:07

close console io after each test
5832f2b

call input flush in function
351baac

update news
e2a7481

Merge branch 'main' into fix-test-msvcrt
822901e

vstinner reviewed Sep 10, 2023
View reviewed changes

add flush_console_input_buffer to replace ctypes in tests
b80cca0

aisk requested a review from a team as a code owner September 11, 2023 09:28

aisk added 2 commits September 11, 2023 18:14

Merge branch 'main' into fix-test-msvcrt
f620ad8

Merge branch 'main' into fix-test-msvcrt
d436f23

Merge branch 'main' into fix-test-msvcrt
8046eac

aisk requested a review from vstinner September 15, 2023 09:57

zooba reviewed Sep 20, 2023
View reviewed changes

Comment threadLib/test/test_msvcrt.py Outdated

do not update the sys.stdin in console tests
dfd3992

vstinner merged commit 4230d7c into python:mainSep 22, 2023

bedevere-appBot removed the awaiting review label Sep 22, 2023

aisk deleted the fix-test-msvcrt branch September 22, 2023 10:20

Uh oh!

Uh oh!

Conversation

aisk commented Sep 10, 2023• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinnerSep 10, 2023

Choose a reason for hiding this comment

Uh oh!

vstinnerSep 10, 2023

Choose a reason for hiding this comment

Uh oh!

aisk commented Sep 10, 2023

Uh oh!

vstinner commented Sep 10, 2023

Uh oh!

aisk commented Sep 11, 2023

Uh oh!

aisk commented Sep 11, 2023

Uh oh!

aisk commented Sep 15, 2023

Uh oh!

Uh oh!

zooba commented Sep 21, 2023

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

bedevere-bot commented Sep 21, 2023

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

bedevere-bot commented Sep 21, 2023

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

vstinner commented Sep 22, 2023

Uh oh!

vstinner commented Sep 22, 2023

Uh oh!

aisk commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aisk commented Sep 10, 2023•
edited by bedevere-bot
Loading