Uh oh!
There was an error while loading. Please reload this page.
gh-109276: libregrtest only checks saved_test_environment() once - #109278
Merged
Conversation
There is no need to check for environment changes twice.
vstinner
commented
Sep 11, 2023
MemberAuthor
@serhiy-storchaka: I think that you reported this issue once somewhere, I don't recall where. |
serhiy-storchaka
self-requested a review
September 11, 2023 17:14
serhiy-storchaka
approved these changes
Sep 11, 2023
Comment on lines
+136
to
+137
| runtests.quiet, | ||
| pgo=runtests.pgo): |
There was a problem hiding this comment.
quiet and pgo are already local variables.
vstinner added a commit
to vstinner/cpython
that referenced
this pull request
Sep 13, 2023
python#109278) There is no need to check for environment changes twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to check for environment changes twice.