Skip to content

gh-109414: Add some basic information about venvs in the introduction. - #109440

Merged
vsajip merged 3 commits into
python:mainfrom
vsajip:fix-109414
Sep 16, 2023
Merged

gh-109414: Add some basic information about venvs in the introduction.#109440
vsajip merged 3 commits into
python:mainfrom
vsajip:fix-109414

Conversation

@vsajip

@vsajipvsajip commented Sep 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@vsajipvsajip added the docs Documentation in the Doc dir label Sep 15, 2023
@bedevere-appbedevere-appBot mentioned this pull request Sep 15, 2023
Closed
vstinner
vstinner reviewed Sep 15, 2023
View reviewed changes
Comment threadDoc/library/venv.rst Outdated
Comment threadDoc/library/venv.rst Outdated
@vstinner

vstinner commented Sep 15, 2023

Copy link
Copy Markdown
Member

I'm using venv as a sandbox to install libraries that I don't want to install system-wide, but your definition implies that.

I'm also using them to modify the code: it's convenient to develop, since changes are "undone" when I remove (and recreate) the venv.

vstinner
vstinner approved these changes Sep 15, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made some suggestions, but you can ignore them ;-)

@vsajip@vstinner
Apply suggestions from code review
43a2f95
Co-authored-by: Victor Stinner <vstinner@python.org>
@vsajip

vsajip commented Sep 15, 2023

Copy link
Copy Markdown
MemberAuthor

I'm using venv as a sandbox to install libraries that I don't want to install system-wide, but your definition implies that.

I'm also using them to modify the code

Yes, the list isn't meant to be exhaustive 😉

vstinner
vstinner approved these changes Sep 15, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the minor updates 😉

@vsajip
vsajip merged commit a6846d4 into python:mainSep 16, 2023
@vsajip
vsajip deleted the fix-109414 branch September 16, 2023 08:49
@vsajipvsajip added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 16, 2023
@miss-islington

miss-islington commented Sep 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2023
@vsajip@vstinner@miss-islington
pythongh-109414: Add some basic information about venvs in the introd…
0d584d7
…uction. (pythonGH-109440)
(cherry picked from commit a6846d4)
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2023
@vsajip@vstinner@miss-islington
pythongh-109414: Add some basic information about venvs in the introd…
fbe857c
…uction. (pythonGH-109440)
(cherry picked from commit a6846d4)
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-appBot commented Sep 16, 2023

Copy link
Copy Markdown

GH-109480 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Sep 16, 2023
@bedevere-app

bedevere-appBot commented Sep 16, 2023

Copy link
Copy Markdown

GH-109481 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 16, 2023
vsajip pushed a commit that referenced this pull request Sep 16, 2023
@miss-islington
[3.11]gh-109414: Add some basic information about venvs in the intro…
e16a9af
…duction. (GH-109440) (GH-109480)
(cherry picked from commit a6846d4)
Yhg1s pushed a commit that referenced this pull request Sep 17, 2023
@miss-islington@vsajip@vstinner
[3.12]gh-109414: Add some basic information about venvs in the intro…
6552879
…duction. (GH-109440) (#109481)
gh-109414: Add some basic information about venvs in the introduction. (GH-109440)
(cherry picked from commit a6846d4)
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Victor Stinner <vstinner@python.org>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vsajip@vstinner@csm10495
pythongh-109414: Add some basic information about venvs in the introd…
b7ff008
…uction. (pythonGH-109440)
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes
@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsajip@vstinner@miss-islington@brettcannon