Skip to content

gh-109408: Azure Pipelines: test 3.12 branch - #109453

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:ap-test-3.12
Sep 18, 2023
Merged

gh-109408: Azure Pipelines: test 3.12 branch#109453
hugovk merged 1 commit into
python:mainfrom
hugovk:ap-test-3.12

Conversation

@hugovk

@hugovkhugovk commented Sep 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

As noted in #109408 (comment), Azure Pipelines CI (ci.yml) runs tests on version branches post-merge.

But it's only running on main and 3.11 and older, and not on 3.12, because we forgot to add it when branching 3.12 from main in May:

Screenshot

image

Also, Azure Pipelines PR (pr.yml) only runs for PRs to main, but I added the missing 3.12 anyway (and am planning on eventually removing it in #109408):

Screenshot

image

Should we remove 3.7 from these lists?

@bedevere-appbedevere-appBot mentioned this pull request Sep 15, 2023
Closed
vstinner
vstinner reviewed Sep 15, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be added to PEP 101 release process to not forget it next time.

@hugovk

hugovk commented Sep 15, 2023

Copy link
Copy Markdown
MemberAuthor

It should be added to PEP 101 release process to not forget it next time.

Looking at PEP 101, should it be added to https://github.com/python/release-tools/blob/master/release.py?

  • Bump version numbers via the release script:
    $ .../release-tools/release.py --bump X.Y.ZaN

@vstinner

vstinner commented Sep 15, 2023

Copy link
Copy Markdown
Member

I didn't understand well the future of Azure Pipelines. If it goes away, updating the release tool is not needed.

@hugovk

hugovk commented Sep 15, 2023

Copy link
Copy Markdown
MemberAuthor

There are two Azure Pipelines runs.

One for PRs (pr.yml) - we're planning on removing this one, it's the one most people would notice.

The other runs on version branches after merging PRs (ci.yml), and it's not visible in PRs. Steve would like to keep this one running to do some extra Windows packaging checks (#109408 (comment)), so that can stay.

@hugovk

hugovk commented Sep 18, 2023

Copy link
Copy Markdown
MemberAuthor

Apologies for the force push, it was a mistake! No changes to the PR other than rebasing on main.

@hugovkhugovk mentioned this pull request Sep 18, 2023
Closed
@hugovk

hugovk commented Sep 18, 2023

Copy link
Copy Markdown
MemberAuthor

It should be added to PEP 101 release process to not forget it next time.

Looking at PEP 101, should it be added to python/release-tools@master/release.py?

  • Bump version numbers via the release script:
    $ .../release-tools/release.py --bump X.Y.ZaN

Issue created: python/release-tools#56

vstinner
vstinner approved these changes Sep 18, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner

vstinner commented Sep 18, 2023

Copy link
Copy Markdown
Member

The other runs on version branches after merging PRs (ci.yml), and it's not visible in PRs. Steve would like to keep this one running to do some extra Windows packaging checks (#109408 (comment)), so that can stay.

Sure, it makes sense. Thanks for the explanation.

@hugovkhugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 18, 2023
@hugovk
hugovk merged commit dd5d214 into python:mainSep 18, 2023
@hugovk
hugovk deleted the ap-test-3.12 branch September 18, 2023 12:37
@miss-islington

miss-islington commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
@hugovk@miss-islington
pythongh-109408: Azure Pipelines: test 3.12 branch (pythonGH-109453)
8aac67a
(cherry picked from commit dd5d214)
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Sep 18, 2023

Copy link
Copy Markdown

GH-109535 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
@hugovk@miss-islington
pythongh-109408: Azure Pipelines: test 3.12 branch (pythonGH-109453)
66bf57a
(cherry picked from commit dd5d214)
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 18, 2023
@bedevere-app

bedevere-appBot commented Sep 18, 2023

Copy link
Copy Markdown

GH-109536 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Sep 18, 2023
hugovk added a commit that referenced this pull request Sep 18, 2023
@miss-islington@hugovk
[3.11]gh-109408: Azure Pipelines: test 3.12 branch (GH-109453) (#109536
26b75b8
)
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Sep 18, 2023
@miss-islington@hugovk
[3.12]gh-109408: Azure Pipelines: test 3.12 branch (GH-109453) (#109535
0620bc7
)
gh-109408: Azure Pipelines: test 3.12 branch (GH-109453)
(cherry picked from commit dd5d214)
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@hugovk@csm10495
pythongh-109408: Azure Pipelines: test 3.12 branch (python#109453)
7c24e26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@vstinner@miss-islington