Skip to content

gh-109496: Skip test_capi.test_decref_freed_object() on ASAN - #109573

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:skip_decref_freed_asan
Sep 19, 2023
Merged

gh-109496: Skip test_capi.test_decref_freed_object() on ASAN#109573
vstinner merged 1 commit into
python:mainfrom
vstinner:skip_decref_freed_asan

Conversation

@vstinner

@vstinnervstinner commented Sep 19, 2023

Copy link
Copy Markdown
Member

Skip test_decref_freed_object() of test_capi.test_misc if Python is built with ASAN, MSAN or UBSAN sanitizers.

Skip test_decref_freed_object() of test_capi.test_misc if Python is
built with ASAN, MSAN or UBSAN sanitizers.
@vstinner

vstinner commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

Strange. GHA Address sanitizer job passed on my PR #109539: job https://github.com/python/cpython/actions/runs/6224015278/job/16891268158.

0:06:16 load avg: 3.28 [247/463] test_capi passed

But it fails on the ASAN buildbot: https://buildbot.python.org/all/#/builders/585/builds/4047

The GHA job and buildbot both use GCC.

Buildbot:

CC.version: gcc (GCC) 12.2.0
sysconfig[PY_CFLAGS]: -fsanitize=address -g -Og -Wall (...)

GHA:

CC.version: gcc (Ubuntu 10.5.0-1ubuntu1~20.04) 10.5.0
sysconfig[PY_CFLAGS]: -fsanitize=address -DNDEBUG -g -O3 (...)

Buildbot and GHA compiler flags are different.

@vstinner
vstinner enabled auto-merge (squash) September 19, 2023 14:22
@vstinner
vstinner merged commit 0a31ff0 into python:mainSep 19, 2023
@vstinner
vstinner deleted the skip_decref_freed_asan branch September 19, 2023 14:42
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 19, 2023
…ythonGH-109573)
Skip test_decref_freed_object() of test_capi.test_misc if Python is
built with ASAN, MSAN or UBSAN sanitizers.
(cherry picked from commit 0a31ff0)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

Copy link
Copy Markdown

GH-109578 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 19, 2023
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.x has failed when building commit 0a31ff0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/509/builds/4934) and take a look at the build logs.
  4. Check if the failure is related to this commit (0a31ff0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/509/builds/4934

Failed tests:

  • test.test_asyncio.test_subprocess

Failed subtests:

  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacksself.loop.run_until_complete(main())
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 664, in run_until_completereturn future.result()
^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_asyncio/test_subprocess.py", line 780, in mainself.assertEqual(events, [
AssertionError: Lists differ: ['process_exited', ('pipe_data_received', 1, b'stdout')] != [('pipe_data_received', 1, b'stdout'), ('p[95 chars]ted']

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 3.x has failed when building commit 0a31ff0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/185/builds/5040) and take a look at the build logs.
  4. Check if the failure is related to this commit (0a31ff0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/185/builds/5040

Failed tests:

  • test.test_asyncio.test_unix_events

Failed subtests:

  • test_fork_signal_handling - test.test_asyncio.test_unix_events.TestFork.test_fork_signal_handling

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/unittest/async_case.py", line 90, in _callTestMethodifself._callMaybeAsync(method) isnotNone:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/unittest/async_case.py", line 117, in _callMaybeAsyncreturnself._asyncioTestContext.run(func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/test/support/hashlib_helper.py", line 49, in wrapperreturn func_or_class(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/test/test_asyncio/test_unix_events.py", line 1937, in test_fork_signal_handlingself.assertTrue(child_handled.is_set())
AssertionError: False is not true

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
…ython#109573)
Skip test_decref_freed_object() of test_capi.test_misc if Python is
built with ASAN, MSAN or UBSAN sanitizers.
pablogsal pushed a commit that referenced this pull request Oct 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@miss-islington@bedevere-bot