Uh oh!
There was an error while loading. Please reload this page.
[3.12] gh-76785: Use Pending Calls When Releasing Cross-Interpreter Data (gh-109556) - #109586
Closed
miss-islington wants to merge 4 commits into
Closed
[3.12] gh-76785: Use Pending Calls When Releasing Cross-Interpreter Data (gh-109556)#109586miss-islington wants to merge 4 commits into
miss-islington wants to merge 4 commits into
Conversation
…ta (pythongh-109556) This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters. (cherry picked from commit fd7e08a) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
This was referenced Sep 19, 2023
ericsnowcurrently
marked this pull request as draft
September 19, 2023 21:02
ericsnowcurrently
commented
Sep 19, 2023
Member
Backporting this to 3.12 will have to be done in a way that does not introduce the new _PyCrossInterpreterData_ReleaseAndRawFree() into the public ABI. |
ericsnowcurrently
marked this pull request as ready for review
October 11, 2023 13:59
Yhg1s
approved these changes
Nov 20, 2023
| #include "pycore_gil.h" // struct _gil_runtime_state | ||
| typedef int (*_Py_pending_call_func)(void *); |
Member
There was a problem hiding this comment.
I don't think this refactoring should be done in 3.12.1. Is there a reason not to leave it just 'int (*func)(void *)' in a few places?
There was a problem hiding this comment.
Yeah, _Py_pending_call_func() is not necessary. I'm fine with dropping it.
ericsnowcurrently
commented
Nov 20, 2023
Member
I didn't figure out how to modify the miss-islington branch so I've created a new PR: gh-112288. |
ericsnowcurrently
commented
Nov 27, 2023
Member
I've merged this change through gh-112288. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some crashes in the _xxinterpchannels module, due to a race between interpreters.
(cherry picked from commit fd7e08a)
Co-authored-by: Eric Snow ericsnowcurrently@gmail.com