Skip to content

gh-109706: Fix multiprocessing test_nested_startmethod() - #109707

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_nested_startmethod
Sep 22, 2023
Merged

gh-109706: Fix multiprocessing test_nested_startmethod()#109707
vstinner merged 1 commit into
python:mainfrom
vstinner:test_nested_startmethod

Conversation

@vstinner

@vstinnervstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member

Don't check order, queue items can be written in any order.

Don't check order, queue items can be written in any order.
@vstinner

Copy link
Copy Markdown
MemberAuthor

cc @pitrou

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. This behavior is arguably non-intuitive...

@vstinner

Copy link
Copy Markdown
MemberAuthor

LGTM, thanks. This behavior is arguably non-intuitive...

Well... I'm no longer surprised by surprising multiprocessing behavior :-D

@vstinner
vstinner merged commit b03a791 into python:mainSep 22, 2023
@vstinner
vstinner deleted the test_nested_startmethod branch September 22, 2023 21:49
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
…nGH-109707)
Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

Copy link
Copy Markdown

GH-109762 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
…nGH-109707)
Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 22, 2023
@bedevere-app

Copy link
Copy Markdown

GH-109763 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
@vstinner

Copy link
Copy Markdown
MemberAuthor

Merged. Thanks for the review @pitrou. I wasn't sure about that one!

vstinner added a commit that referenced this pull request Sep 22, 2023
…09707) (#109763)
gh-109706: Fix multiprocessing test_nested_startmethod() (GH-109707)
Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)
Co-authored-by: Victor Stinner <vstinner@python.org>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
…n#109707)
Don't check order, queue items can be written in any order.
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
…09707) (#109762)
gh-109706: Fix multiprocessing test_nested_startmethod() (GH-109707)
Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)
Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…n#109707)
Don't check order, queue items can be written in any order.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@miss-islington@pitrou