Skip to content

ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner - #109737

Merged
ambv merged 3 commits into
python:mainfrom
AA-Turner:docs/ostricher-oren
Sep 22, 2023
Merged

ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner #109737
ambv merged 3 commits into
python:mainfrom
AA-Turner:docs/ostricher-oren

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Sep 22, 2023

Copy link
Copy Markdown
Member

cc: @itamaro

Following on from #109661, hope you don't mind me opening the PR!

A

@AA-TurnerAA-Turner added docs Documentation in the Doc dir skip issue skip news labels Sep 22, 2023
@hugovk

hugovk commented Sep 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

As we're editing this, the last two names were tacked on the end, instead of being in "rough alphabetical order by last names". (But not the name beginning Å, that comes after Z.)

Would you like to slot them back into place?

@AA-Turner

AA-Turner commented Sep 22, 2023

Copy link
Copy Markdown
MemberAuthor

Doroschenko is already present in the right order, it seems! I also took the liberty of adding myself, if that's alright?

A

@AA-TurnerAA-Turner changed the title ACKS: Correct Itamar Oren's surnameACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner Sep 22, 2023
itamaro
itamaro approved these changes Sep 22, 2023
View reviewed changes

@itamaroitamaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AA-TurnerAA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 22, 2023
ambv
ambv reviewed Sep 22, 2023
View reviewed changes
Comment threadMisc/ACKS
@ambv
ambv merged commit 3e8fcb7 into python:mainSep 22, 2023
@miss-islington

miss-islington commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@AA-Turner@miss-islington
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
2f6939b
…ythonGH-109737)
(cherry picked from commit 3e8fcb7)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109741 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@AA-Turner@miss-islington
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
6a5cca6
…ythonGH-109737)
(cherry picked from commit 3e8fcb7)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109742 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
AlexWaygood pushed a commit that referenced this pull request Sep 22, 2023
@miss-islington@AA-Turner
[3.11] ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Tu…
567c3e8
…rner (GH-109737) (#109742)
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (GH-109737)
(cherry picked from commit 3e8fcb7)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Sep 22, 2023
@miss-islington@AA-Turner
[3.12] ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Tu…
f6287bd
…rner (GH-109737) (#109741)
(cherry picked from commit 3e8fcb7)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AA-Turner@csm10495
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
ff9ecae
…ython#109737)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner@Glyphack
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
f22c33a
…ython#109737)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments
@carljmcarljmcarljm approved these changes
@itamaroitamaroitamaro approved these changes
@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AA-Turner@hugovk@miss-islington@ambv@carljm@itamaro