Skip to content

GH-109190: Copyedit 3.12 What's New: Update the imp porting guidance - #109755

Merged
hugovk merged 1 commit into
python:mainfrom
AA-Turner:docs/whatsnew/imp-porting
Sep 25, 2023
Merged

GH-109190: Copyedit 3.12 What's New: Update the imp porting guidance#109755
hugovk merged 1 commit into
python:mainfrom
AA-Turner:docs/whatsnew/imp-porting

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Sep 22, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member
  • This merges three bullets into one, and rewords the lead to make it clear that this is a guide to porting rather than an internal change to Python.

📚 Documentation preview 📚: https://cpython-previews--109755.org.readthedocs.build/

@AA-TurnerAA-Turner added the needs backport to 3.12 only security fixes label Sep 22, 2023
@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Sep 22, 2023
@bedevere-appbedevere-appBot mentioned this pull request Sep 22, 2023
Closed
@hugovk

hugovk commented Sep 22, 2023

Copy link
Copy Markdown
Member

There's also a "Porting to Python 3.12" section further down the page, should some of this be moved there, with a link to it?

Similar to how "tokenize" does it?

@AA-Turner

AA-Turner commented Sep 22, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I wasn't sure on moving to Porting so opted for the less invasive change initially. I'd agree it makes sense (& we can include a cross-ref from 'Removed'), cc @vstinner for thoughts as the author of #105905 (#104212).

A

vstinner
vstinner approved these changes Sep 24, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
hugovk merged commit 7b8bfe1 into python:mainSep 25, 2023
@miss-islington

miss-islington commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2023
@AA-Turner@miss-islington
pythonGH-109190: Copyedit 3.12 What's New: Update theimpporting…
f1b4d30
… guidance (pythonGH-109755)
(cherry picked from commit 7b8bfe1)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Sep 25, 2023

Copy link
Copy Markdown

GH-109816 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 25, 2023
Yhg1s pushed a commit that referenced this pull request Sep 25, 2023
@miss-islington@AA-Turner
[3.12]GH-109190: Copyedit 3.12 What's New: Update theimpportin…
52b2f9f
…g guidance (GH-109755) (#109816)
GH-109190: Copyedit 3.12 What's New: Update the ``imp`` porting guidance (GH-109755)
(cherry picked from commit 7b8bfe1)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AA-Turner@csm10495
pythonGH-109190: Copyedit 3.12 What's New: Update theimpporting…
58ed026
… guidance (python#109755)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner@Glyphack
pythonGH-109190: Copyedit 3.12 What's New: Update theimpporting…
1ad7ef4
… guidance (python#109755)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@hugovkhugovkhugovk approved these changes
@ambvambvAwaiting requested review from ambv

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AA-Turner@hugovk@miss-islington@vstinner