GH-109408: Move the Python file whitespace check from patchcheck to pre-commit

[AA-Turner]

• Issue: Move Azure Pipelines CI to GitHub Actions #109408

[hugovk]

Thanks!

[miss-islington]

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

[miss-islington]

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

[miss-islington]

Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 08ec4a1dbf66383303de9ce5cb55b2b437ef92c0 3.11

[bedevere-app]

GH-110633 is a backport of this pull request to the 3.12 branch.

[hugovk]

@AA-Turner Please could you take care of the backports in #109890 and here?

[bedevere-app]

GH-110641 is a backport of this pull request to the 3.11 branch.

[hugovk]

I've found a problem with this (and the C one) when running on macOS, pre-commit cannot find an executable called python:

❯ pre-commit run --all-filesRun Ruff on Lib/test/....................................................PassedRun Ruff on Argument Clinic..............................................Passedcheck toml...............................................................Passedcheck yaml...............................................................Passedfix end of files.........................................................Passedtrim trailing whitespace.................................................PassedCheck Python file whitespace.............................................Failed- hook id: python-file-whitespace- exit code: 1Executable `python` not foundCheck C file whitespace..................................................Failed- hook id: c-file-whitespace- exit code: 1Executable `python` not foundSphinx lint..............................................................PassedCheck hooks apply to the repository......................................PassedCheck for useless excludes...............................................Passed

It works with python3, but that's not going to work with Windows.

Is there a portable solution?

One option could be like https://github.com/pre-commit/pre-commit-hooks/blob/main/.pre-commit-hooks.yaml which has entries such as:

- id: check-added-large-filesname: check for added large filesdescription: prevents giant files from being committed.entry: check-added-large-fileslanguage: pythonstages: [commit, push, manual]

Which uses a file like https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_added_large_files.py

[hugovk]

(So let's hold off on the remaining backports until this is fixed.)

[AA-Turner]

The pre-commit website (implicitly) suggested using python for system languages, I hadn't realised it wouldn't work on Macs.

The drawback with language: python is that it seems there's no option to run outwith a venv, so we'd suffer an unnecessary slowdown.

A