gh-109615: Fix test_tools.test_freeze SRCDIR by vstinner · Pull Request #109935 · python/cpython

vstinner · 2023-09-26T23:00:20Z

Use sysconfig to get the source directory.
Use sysconfig.get_config_var() to get CONFIG_ARGS variable.

Issue: test_tools: test_freeze_simple_script() fails on s390x SLES 3.x: [Errno 2] No such file or directory: (...) #109615

vstinner · 2023-09-26T23:01:38Z

!buildbot s390x SLES

bedevere-bot · 2023-09-26T23:01:41Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit a57099f 🤖

The command will test the builders whose names match following regular expression: s390x SLES

The builders matched are:

s390x SLES PR

vstinner · 2023-09-26T23:02:37Z

!buildbot s390x Debian

bedevere-bot · 2023-09-26T23:02:39Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit a57099f 🤖

The command will test the builders whose names match following regular expression: s390x Debian

The builders matched are:

s390x Debian PR

vstinner · 2023-09-26T23:03:59Z

I'm not sure why previously, a subprocess was spawned to run "python -c sysconfig.get_config_var(...)", rather than using directly sysconfig.get_config_var(). The frozen app can target a different Python program?

vstinner · 2023-09-26T23:05:50Z

@ericsnowcurrently: You added Tools/freeze/test/ in commit 13d9205. Do you recall why you didn't use sysconfig directly?

vstinner · 2023-09-26T23:19:20Z

!buildbot s390x SLES

bedevere-bot · 2023-09-26T23:19:22Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 79c94b1 🤖

The command will test the builders whose names match following regular expression: s390x SLES

The builders matched are:

s390x SLES PR

vstinner · 2023-09-26T23:19:31Z

!buildbot s390x Debian

bedevere-bot · 2023-09-26T23:19:33Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 79c94b1 🤖

The command will test the builders whose names match following regular expression: s390x Debian

The builders matched are:

s390x Debian PR

ericsnowcurrently · 2023-09-26T23:41:59Z

@ericsnowcurrently: You added Tools/freeze/test/ in commit 13d9205. Do you recall why you didn't use sysconfig directly?

I don't recall. I may have copied it from somewhere, or had trouble using sysconfig, or something else. Sorry. Wish I remembered.

vstinner · 2023-09-27T00:34:44Z

!buildbot wasm32-wasi

bedevere-bot · 2023-09-27T00:34:46Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 9c111be 🤖

The command will test the builders whose names match following regular expression: wasm32-wasi

The builders matched are:

wasm32-wasi PR

vstinner · 2023-09-27T00:34:54Z

!buildbot s390x Debian

bedevere-bot · 2023-09-27T00:34:56Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 9c111be 🤖

The command will test the builders whose names match following regular expression: s390x Debian

The builders matched are:

s390x Debian PR

Fix copy_source_tree() function of test_tools.test_freeze: * Don't copy SRC_DIR/build/ anymore. This directory is modified by other tests running in parallel. * Add test.support.copy_python_src_ignore(). * Use sysconfig to get the source directory. * Use sysconfig.get_config_var() to get CONFIG_ARGS variable.

miss-islington · 2023-09-27T08:18:43Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington · 2023-09-27T08:18:44Z

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1512d6c6ee2a770afb339bbb74c1b990116f7f89 3.12

miss-islington · 2023-09-27T08:18:47Z

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1512d6c6ee2a770afb339bbb74c1b990116f7f89 3.11

Fix copy_source_tree() function of test_tools.test_freeze: * Don't copy SRC_DIR/build/ anymore. This directory is modified by other tests running in parallel. * Add test.support.copy_python_src_ignore(). * Use sysconfig to get the source directory. * Use sysconfig.get_config_var() to get CONFIG_ARGS variable. (cherry picked from commit 1512d6c)

bedevere-app · 2023-09-27T08:32:02Z

GH-109950 is a backport of this pull request to the 3.12 branch.

Fix copy_source_tree() function of test_tools.test_freeze: * Don't copy SRC_DIR/build/ anymore. This directory is modified by other tests running in parallel. * Add test.support.copy_python_src_ignore(). * Use sysconfig to get the source directory. * Use sysconfig.get_config_var() to get CONFIG_ARGS variable. (cherry picked from commit 1512d6c)

bedevere-app · 2023-09-27T08:36:10Z

GH-109951 is a backport of this pull request to the 3.11 branch.

gh-109615: Fix test_tools.test_freeze SRCDIR (#109935) Fix copy_source_tree() function of test_tools.test_freeze: * Don't copy SRC_DIR/build/ anymore. This directory is modified by other tests running in parallel. * Add test.support.copy_python_src_ignore(). * Use sysconfig to get the source directory. * Use sysconfig.get_config_var() to get CONFIG_ARGS variable. (cherry picked from commit 1512d6c)

Fix copy_source_tree() function of test_tools.test_freeze: * Don't copy SRC_DIR/build/ anymore. This directory is modified by other tests running in parallel. * Add test.support.copy_python_src_ignore(). * Use sysconfig to get the source directory. * Use sysconfig.get_config_var() to get CONFIG_ARGS variable.

gh-109615: Fix test_tools.test_freeze SRCDIR (#109935) Fix copy_source_tree() function of test_tools.test_freeze: * Don't copy SRC_DIR/build/ anymore. This directory is modified by other tests running in parallel. * Add test.support.copy_python_src_ignore(). * Use sysconfig to get the source directory. * Use sysconfig.get_config_var() to get CONFIG_ARGS variable. (cherry picked from commit 1512d6c)

Fix copy_source_tree() function of test_tools.test_freeze: * Don't copy SRC_DIR/build/ anymore. This directory is modified by other tests running in parallel. * Add test.support.copy_python_src_ignore(). * Use sysconfig to get the source directory. * Use sysconfig.get_config_var() to get CONFIG_ARGS variable.

vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 26, 2023

bedevere-appBot mentioned this pull request Sep 26, 2023
test_tools: test_freeze_simple_script() fails on s390x SLES 3.x: [Errno 2] No such file or directory: (...) #109615
Closed

vstinner added the skip news label Sep 26, 2023

vstinner force-pushed the freeze_src_dir branch 2 times, most recently from 2c0ff04 to 9c111beCompare September 27, 2023 00:34

vstinner marked this pull request as ready for review September 27, 2023 07:46

vstinner requested a review from vsajip as a code owner September 27, 2023 07:46

bedevere-appBot added the awaiting review label Sep 27, 2023

vstinner force-pushed the freeze_src_dir branch from 9c111be to 458a4d4Compare September 27, 2023 07:54

vstinner enabled auto-merge (squash) September 27, 2023 07:56

vstinner merged commit 1512d6c into python:mainSep 27, 2023

vstinner deleted the freeze_src_dir branch September 27, 2023 08:18

bedevere-appBot removed the awaiting review label Sep 27, 2023

miss-islington assigned vstinner Sep 27, 2023

bedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 27, 2023

bedevere-appBot removed the needs backport to 3.11 only security fixes label Sep 27, 2023

Uh oh!

Uh oh!

Conversation

vstinner commented Sep 26, 2023• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Sep 26, 2023

Uh oh!

bedevere-bot commented Sep 26, 2023

Uh oh!

vstinner commented Sep 26, 2023

Uh oh!

bedevere-bot commented Sep 26, 2023

Uh oh!

vstinner commented Sep 26, 2023

Uh oh!

vstinner commented Sep 26, 2023

Uh oh!

vstinner commented Sep 26, 2023

Uh oh!

bedevere-bot commented Sep 26, 2023

Uh oh!

vstinner commented Sep 26, 2023

Uh oh!

bedevere-bot commented Sep 26, 2023

Uh oh!

ericsnowcurrently commented Sep 26, 2023

Uh oh!

vstinner commented Sep 27, 2023

Uh oh!

bedevere-bot commented Sep 27, 2023

Uh oh!

vstinner commented Sep 27, 2023

Uh oh!

bedevere-bot commented Sep 27, 2023

Uh oh!

miss-islington commented Sep 27, 2023

Uh oh!

miss-islington commented Sep 27, 2023

Uh oh!

miss-islington commented Sep 27, 2023

Uh oh!

bedevere-appBot commented Sep 27, 2023

Uh oh!

bedevere-appBot commented Sep 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vstinner commented Sep 26, 2023•
edited by bedevere-app Bot
Loading