Uh oh!
There was an error while loading. Please reload this page.
gh-104909: Make LOAD_ATTR_PROPERTY a viable uop - #110560
Closed
gvanrossum wants to merge 3 commits into
Closed
Conversation
gvanrossumforce-pushed
the
load-attr-uops
branch
from
October 10, 2023 11:40
8dcbe3a to
fff4211Comparegvanrossumforce-pushed
the
load-attr-uops
branch
2 times, most recently
from
November 1, 2023 22:59
2deceef to
067b489Comparegvanrossumforce-pushed
the
load-attr-uops
branch
from
November 18, 2023 02:27
067b489 to
99ec298Comparegvanrossumforce-pushed
the
load-attr-uops
branch
from
November 18, 2023 06:19
99ec298 to
0b71d63Comparegvanrossum
commented
Nov 18, 2023
MemberAuthor
Alas, this will go nowhere. (See issue.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are severe problems here.
LOAD_ATTR_PROPERTYtakes afunc_versioncache entry an anfgetcache entry, which need to be cross-checked (fget->func_version == func_version) but a single uop cannot reference two cache entries.The immediate fix (after rearranging the cache entries) is to load
fgetonto the stack. However, this isn't safe, because it will break whenDEOPT_IF()jumps back to the unspecialized opcode (since the stack is different).Moreover, I needed to disable two assertions from the code generator. It's possible there's a better way, but I'd have to think, and it's not worth it unless we solve the other problem.
This draft PR just exists to find out what else CI finds.