Skip to content

gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation - #110702

Merged
pablogsal merged 13 commits into
python:mainfrom
pablogsal:traceback
Oct 12, 2023
Merged

gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation#110702
pablogsal merged 13 commits into
python:mainfrom
pablogsal:traceback

Conversation

@pablogsal

@pablogsalpablogsal commented Oct 11, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@iritkatriel

iritkatriel commented Oct 11, 2023

Copy link
Copy Markdown
Member

If no tests are failing then the fallback is not tested.

@pablogsal

pablogsal commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

If no tests are failing then the fallback is not tested.

Yup, currently working on adapting the tests. Sorry, I forgot to mark it as a draft.

@pablogsal
pablogsal marked this pull request as draft October 11, 2023 12:11
@pablogsal
pablogsal marked this pull request as ready for review October 11, 2023 14:46
@pablogsalpablogsal changed the title Use the traceback module for PyErr_Display() and fallback to the C implementationgh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementationOct 11, 2023
@bedevere-appbedevere-appBot mentioned this pull request Oct 11, 2023
Closed
iritkatriel
iritkatriel approved these changes Oct 11, 2023
View reviewed changes
Comment threadLib/test/test_traceback.py Outdated
Comment threadLib/traceback.py Outdated
@iritkatrieliritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 11, 2023
@bedevere-bot

bedevere-bot commented Oct 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c812a3c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 11, 2023
@pablogsalpablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2023
@bedevere-bot

bedevere-bot commented Oct 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d55b7e7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2023
iritkatriel
iritkatriel reviewed Oct 12, 2023
View reviewed changes
Comment threadLib/test/test_sys.py
@pablogsalpablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2023
@bedevere-bot

bedevere-bot commented Oct 12, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4d438ec 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2023
iritkatriel
iritkatriel reviewed Oct 12, 2023
View reviewed changes
Comment threadPython/pythonrun.c Outdated
Comment threadPython/pythonrun.c Outdated
Comment threadPython/pythonrun.c Outdated
Comment threadPython/pythonrun.c Outdated
Comment threadPython/pythonrun.c Outdated
Comment threadPython/pythonrun.c Outdated
@pablogsal
pablogsal enabled auto-merge (squash) October 12, 2023 14:22
@pablogsal
pablogsal merged commit e733136 into python:mainOct 12, 2023
@pablogsal
pablogsal deleted the traceback branch October 12, 2023 14:52
This was referenced Nov 9, 2023
Open
Closed
@perrinjeromeperrinjerome mentioned this pull request Jan 17, 2024
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal@Glyphack
pythongh-110721: Use the traceback module for PyErr_Display() and fal…
0330b2a
…lback to the C implementation (python#110702)
@nineteendonineteendo mentioned this pull request Dec 3, 2024
Closed
@nineteendonineteendo mentioned this pull request Dec 11, 2024
Merged
@gpsheadgpshead mentioned this pull request Feb 11, 2025
Merged
@tideofwordstideofwords mentioned this pull request Aug 26, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaou
@ambvambvAwaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal@iritkatriel@bedevere-bot