Uh oh!
There was an error while loading. Please reload this page.
gh-110722: Add PYTHON_PRESITE to import a module before site.py is run - #110769
Conversation
… before site.py is run This is only available --with-pydebug.
vstinner
left a comment
There was a problem hiding this comment.
It may be interesting to make this feature to release build.
For the doc, I suggest to replace package.module with module. You can explain in the doc that the argument can be a module of a package, with an example. I don't know.
Overall, the implementation looks correct.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gpshead
left a comment
There was a problem hiding this comment.
LGTM - some minor cleanup to do, feel free to merge after that if CI says "ano" (CZ)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
left a comment
There was a problem hiding this comment.
I'm fine with the C implementation and the overall feature, I just have some remarks on the doc.
I suggest to replace site.py with the site module. In Sphinx, you can even create a link if you want:
the :mod:`site` module
The presite module is imported, it's exactly run. But I'm fine with run_presite name :-) Well, in fact, it can be seed as being "run" ;-)
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Oct 15, 2023
Congrats! |
This is only available --with-pydebug.
📚 Documentation preview 📚: https://cpython-previews--110769.org.readthedocs.build/