Skip to content

gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase - #110776

Merged
gvanrossum merged 6 commits into
python:mainfrom
graingert:unittest-loop-factory
Oct 31, 2023
Merged

gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase#110776
gvanrossum merged 6 commits into
python:mainfrom
graingert:unittest-loop-factory

Conversation

@graingert

@graingertgraingert commented Oct 12, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@graingertgraingert changed the title allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCasegh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCaseOct 12, 2023
@graingertgraingert changed the title gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCasegh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCaseOct 12, 2023
@bedevere-appbedevere-appBot mentioned this pull request Oct 12, 2023
Closed
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment threadDoc/library/unittest.rst Outdated
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment threadDoc/library/unittest.rst
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment threadDoc/library/unittest.rst
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment threadDoc/library/unittest.rst Outdated
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment threadLib/test/test_unittest/test_async_case.py Outdated
@graingert
graingertforce-pushed the unittest-loop-factory branch from 47669b3 to 0fbb894CompareOctober 12, 2023 15:20
@graingert
graingert marked this pull request as ready for review October 12, 2023 15:32
willingc
willingc approved these changes Oct 13, 2023
View reviewed changes

@willingcwillingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert. This looks good to me.

gvanrossum
gvanrossum approved these changes Oct 31, 2023
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

@gvanrossum
gvanrossum merged commit 7705306 into python:mainOct 31, 2023
@graingert
graingert deleted the unittest-loop-factory branch October 31, 2023 22:32
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@graingert@ambv
@willingc@FullteaR
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
3512380
…atedAsyncioTestCase (python#110776)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@graingert@ambv
@willingc@aisk
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
73dc956
…atedAsyncioTestCase (python#110776)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@graingert@ambv
@willingc@Glyphack
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
47d7b80
…atedAsyncioTestCase (python#110776)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingcwillingcwillingc approved these changes
@gvanrossumgvanrossumgvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@graingert@willingc@gvanrossum@ambv