Skip to content

gh-107450: Fix testMemoryErrorBigSource in test_exceptions - #110871

Closed
serhiy-storchaka wants to merge 1 commit into
python:mainfrom
serhiy-storchaka:test_exceptions-testMemoryErrorBigSource
Closed

gh-107450: Fix testMemoryErrorBigSource in test_exceptions#110871
serhiy-storchaka wants to merge 1 commit into
python:mainfrom
serhiy-storchaka:test_exceptions-testMemoryErrorBigSource

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Oct 14, 2023

Copy link
Copy Markdown
Member
  1. It uses 4GB of memory, not 3GB.
  2. It should be skipped if not enough memory
  3. Scope is too wide: the error may occur not only at compile time, but may also occur when the source line is generated or when the compiled code is executed.

@serhiy-storchaka

Copy link
Copy Markdown
MemberAuthor

This PR also slightly optimizes the test: now it is 7 seconds faster on my computer (23 seconds instead of 30 seconds).

@lysnikolaou

Copy link
Copy Markdown
Member

@serhiy-storchaka I've opened #110832 that fixes the test. Maybe push the optimization to that branch?

@serhiy-storchaka

Copy link
Copy Markdown
MemberAuthor

Included in #110832.

@serhiy-storchaka
serhiy-storchaka deleted the test_exceptions-testMemoryErrorBigSource branch July 1, 2026 17:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core reviewskip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@lysnikolaou