Skip to content

gh-110828: AIX 32bit build needs -latomic for _testcapi module#110962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 5 commits into from
Oct 22, 2023
Merged

gh-110828: AIX 32bit build needs -latomic for _testcapi module #110962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d583141
pythongh-110828: AIX 32bit build needs -latomic for _testcapi module
ayappanec Oct 17, 2023
0b9d837
Add NEWS entry
ayappanec Oct 17, 2023
0250c57
Re-generate configure file
ayappanec Oct 17, 2023
44f45b9
Update Misc/NEWS.d/next/Build/2023-10-17-03-10-40.gh-issue-110828.31v…
erlend-aasland Oct 20, 2023
bfb4cca
Remove superfluous quote
erlend-aasland Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2023-10-17-03-10-40.gh-issue-110828.31vQ9B.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
AIX 32bit needs ``-latomic`` to build the :mod:`!_testcapi` extension module.
3 changes: 2 additions & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions configure.ac
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7051,7 +7051,8 @@ int main()
])

AS_VAR_IF([ac_cv_libatomic_needed], [yes],
[LIBS="${LIBS} -latomic"])
[LIBS="${LIBS} -latomic"
LIBATOMIC=${LIBATOMIC-"-latomic"}])
_RESTORE_VAR([CPPFLAGS])


Expand DownExpand Up@@ -7323,7 +7324,10 @@ PY_STDLIB_MOD([_hashlib], [], [test "$ac_cv_working_openssl_hashlib" = yes],
[$OPENSSL_INCLUDES], [$OPENSSL_LDFLAGS $OPENSSL_LDFLAGS_RPATH $LIBCRYPTO_LIBS])

dnl test modules
PY_STDLIB_MOD([_testcapi], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_testcapi],
[test "$TEST_MODULES" = yes],
dnl Modules/_testcapi needs -latomic for 32bit AIX build
[], [], [$LIBATOMIC])
PY_STDLIB_MOD([_testclinic], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_testclinic_limited], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_testinternalcapi], [test "$TEST_MODULES" = yes])
Expand Down