Skip to content

gh-110950: add upstream Tk fixes to macOS installer. - #111041

Merged
ned-deily merged 6 commits into
python:mainfrom
chrstphrchvz:patch-gh110950
Nov 21, 2023
Merged

gh-110950: add upstream Tk fixes to macOS installer.#111041
ned-deily merged 6 commits into
python:mainfrom
chrstphrchvz:patch-gh110950

Conversation

@chrstphrchvz

@chrstphrchvzchrstphrchvz commented Oct 18, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@chrstphrchvz
chrstphrchvz requested a review from a team as a code ownerOctober 18, 2023 17:32
@bedevere-appbedevere-appBot mentioned this pull request Oct 18, 2023
Closed
@chrstphrchvz

chrstphrchvz commented Oct 18, 2023

Copy link
Copy Markdown
ContributorAuthor

As with #108693 and #108806, I have not already attempted to build the macOS installer myself.

@ned-deilyned-deily changed the title gh-110950: add upstream fix to macOS installergh-110950: add upstream Tk fixes to macOS installer.Nov 21, 2023
@ned-deily
ned-deily merged commit d67f947 into python:mainNov 21, 2023
@miss-islington-app

miss-islington-appBot commented Nov 21, 2023

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 21, 2023

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2023
@chrstphrchvz@ned-deily@miss-islington
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
79e822d
…111041)
Add upstream Tk patches for three problems affecting tkinter users:
- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)
- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)
- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)
(cherry picked from commit d67f947)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Ned Deily <nad@python.org>
@bedevere-app

bedevere-appBot commented Nov 21, 2023

Copy link
Copy Markdown

GH-112293 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2023
@chrstphrchvz@ned-deily@miss-islington
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
d641520
…111041)
Add upstream Tk patches for three problems affecting tkinter users:
- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)
- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)
- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)
(cherry picked from commit d67f947)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Ned Deily <nad@python.org>
@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Nov 21, 2023
@bedevere-app

bedevere-appBot commented Nov 21, 2023

Copy link
Copy Markdown

GH-112294 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 21, 2023
@chrstphrchvz
chrstphrchvz deleted the patch-gh110950 branch November 21, 2023 08:20
This was referenced Nov 21, 2023
Closed
Closed
ned-deily added a commit that referenced this pull request Nov 21, 2023
@miss-islington@chrstphrchvz@ned-deily
[3.11]gh-110950: add upstream Tk fixes to macOS installer. (GH-111041)…
253ad78
… (#112293)
Add upstream Tk patches for three problems affecting tkinter users:
- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (gh-92603)
- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (gh-71383)
- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (gh-110950)
(cherry picked from commit d67f947)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Ned Deily <nad@python.org>
ned-deily added a commit that referenced this pull request Nov 21, 2023
@miss-islington@chrstphrchvz@ned-deily
[3.12]gh-110950: add upstream Tk fixes to macOS installer. (GH-111041)…
fab9824
… (#112294)
Add upstream Tk patches for three problems affecting tkinter users:
- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (gh-92603)
- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (gh-71383)
- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (gh-110950)
(cherry picked from commit d67f947)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Ned Deily <nad@python.org>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@chrstphrchvz@ned-deily@aisk
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
19c76ff
…111041)
Add upstream Tk patches for three problems affecting tkinter users:
- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)
- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)
- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)
Co-authored-by: Ned Deily <nad@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@chrstphrchvz@ned-deily@Glyphack
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
95cecbd
…111041)
Add upstream Tk patches for three problems affecting tkinter users:
- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)
- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)
- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)
Co-authored-by: Ned Deily <nad@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deilyned-deilyned-deily approved these changes

Assignees

No one assigned

Labels

OS-mactopic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrstphrchvz@ned-deily@hugovk