gh-94808: Add coverage test for number check - #111445

Merged

corona10 merged 5 commits into

python:mainfrom

ekohilas:gh-94808

Oct 29, 2023

ekohilas commented Oct 29, 2023

Contributor

Add coverage test for number check

gh-94808: Adds a coverage test for PyNumber_Check as part of #94808

Thanks to @corona10 for helping out!

Add aoverage test for number check

91daa4d

ghost commented Oct 29, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.

bedevere-appBot added the awaiting review label

bedevere-appBot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

📜🤖 Added by blurb_it.

08c5af9

corona10 changed the title ~~Add coverage test for number check~~gh-94808: Add coverage test for number check

corona10 added the skip issue label

bedevere-appBot mentioned this pull request

Metabug: Improving C-level coverage #94808

Open

corona10 added skip news and removed skip issue labels

corona10 self-assigned this

corona10 reviewed

View reviewed changes

Lib/test/test_capi/test_abstract.py Outdated

corona10 reviewed

View reviewed changes

Lib/test/test_capi/test_abstract.py

corona10 reviewed

View reviewed changes

Lib/test/test_capi/test_abstract.py

corona10 reviewed

View reviewed changes

corona10 left a comment

Member

Would you like to extend the test to test float, and integer too?
And also for false tests for 'str' or something other types?
Looks like there is no explicit test for this API :)

ekohilasand others added 2 commits

October 29, 2023 08:12

Update Lib/test/test_capi/test_abstract.py

9baf417

Co-authored-by: Donghee Na <donghee.na92@gmail.com>

Update Lib/test/test_capi/test_abstract.py

445bcc0

Co-authored-by: Donghee Na <donghee.na92@gmail.com>

corona10 reviewed

View reviewed changes

Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst Outdated

		@@ -0,0 +1 @@
		Add a C API test for the PyNumber_Check function.

corona10Oct 29, 2023•
edited
Loading

Member

And please remove this file too :)

Update Lib/test/test_capi/test_abstract.py

fd3d99c

Co-authored-by: Donghee Na <donghee.na92@gmail.com>

ekohilas force-pushed the gh-94808 branch from 864c868 to fd3d99cCompare

October 29, 2023 06:33

ekohilas requested a review from corona10

October 29, 2023 06:33

corona10 approved these changes

View reviewed changes

corona10 left a comment

Member

lgtm!

bedevere-appBot added awaiting merge and removed awaiting review labels

corona10 enabled auto-merge (squash)

October 29, 2023 06:41

corona10 merged commit 842e5fc into python:main

bedevere-appBot removed the awaiting merge label

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request

pythongh-94808: Add coverage test for number check (pythongh-111445)

f2fc8ee

FullteaR pushed a commit to FullteaR/cpython that referenced this pull request

pythongh-94808: Add coverage test for number check (pythongh-111445)

55e150c

aisk pushed a commit to aisk/cpython that referenced this pull request

pythongh-94808: Add coverage test for number check (pythongh-111445)

9a981fd

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

pythongh-94808: Add coverage test for number check (pythongh-111445)

af287e6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment