Skip to content

gh-111417: Remove unused code block in math.trunc() and builtin_round_impl - #111454

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
Jason-Y-Z:fix-issue-111417
Feb 3, 2024
Merged

gh-111417: Remove unused code block in math.trunc() and builtin_round_impl#111454
serhiy-storchaka merged 1 commit into
python:mainfrom
Jason-Y-Z:fix-issue-111417

Conversation

@Jason-Y-Z

@Jason-Y-ZJason-Y-Z commented Oct 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Remove unused code block in math.trunc() and builtin_round_impl as mentioned in #111417

@bedevere-appbedevere-appBot mentioned this pull request Oct 29, 2023
Closed
@skirpichev

skirpichev commented Oct 29, 2023

Copy link
Copy Markdown
Member

I suggest adding some text explaining reasons for removal. Either in the commit message or in the pr description (which may become a commit message).

willingc
willingc reviewed Oct 29, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-10-29-11-51-04.gh-issue-111417.LkmWKc.rst Outdated
willingc
willingc reviewed Oct 29, 2023
View reviewed changes
Comment threadModules/mathmodule.c
@Jason-Y-Z

Jason-Y-Z commented Nov 7, 2023

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka sorry for asking but any thoughts?

serhiy-storchaka
serhiy-storchaka reviewed Dec 7, 2023
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I have said on the issue, this change looks safe to me. Do you mind to remove also a similar code in round()?

Comment threadMisc/NEWS.d/next/Library/2023-10-29-11-51-04.gh-issue-111417.LkmWKc.rst Outdated
@Jason-Y-ZJason-Y-Z changed the title gh-111417: Remove unused code block in math.trunc()gh-111417: Remove unused code block in math.trunc() and builtin_round_implFeb 3, 2024
@Jason-Y-Z

Jason-Y-Z commented Feb 3, 2024

Copy link
Copy Markdown
ContributorAuthor

As I have said on the issue, this change looks safe to me. Do you mind to remove also a similar code in round()?

Sorry for the delay, I've made the updates. @serhiy-storchaka

serhiy-storchaka
serhiy-storchaka approved these changes Feb 3, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka
serhiy-storchaka merged commit efc4890 into python:mainFeb 3, 2024
@Jason-Y-Z
Jason-Y-Z deleted the fix-issue-111417 branch February 3, 2024 19:40
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Jason-Y-Z@aisk
pythongh-111417: Remove unused code block in math.trunc() and round() (…
6ee8a57
…pythonGH-111454)
_PyObject_LookupSpecial() now ensures that the type is ready.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@Jason-Y-Z@fsc-eriker
pythongh-111417: Remove unused code block in math.trunc() and round() (…
8e8de6c
…pythonGH-111454)
_PyObject_LookupSpecial() now ensures that the type is ready.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingcwillingcwillingc left review comments
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jason-Y-Z@skirpichev@willingc@serhiy-storchaka