Uh oh!
There was an error while loading. Please reload this page.
gh-108082: C API: Add tests for PyErr_WriteUnraisable() - #111455
Merged
serhiy-storchaka merged 3 commits intoOct 30, 2023
Merged
gh-108082: C API: Add tests for PyErr_WriteUnraisable()#111455serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
Also document the behavior when called with NULL.
Comment on lines
+98
to
+99
| .. versionchanged:: 3.4 | ||
| Print a traceback. Print only traceback if *obj* is ``NULL``. |
MemberAuthor
Comment on lines
+101
to
+102
| .. versionchanged:: 3.8 | ||
| Use :func:`sys.unraisablehook`. |
MemberAuthor
Comment on lines
+95
to
+96
| .. versionchanged:: 3.2 | ||
| Accept ``NULL`` as argument. |
MemberAuthor
There was a problem hiding this comment.
Actually, it was cosmetic change. It skipped " in <NULL>" if obj is NULL.
vstinner
approved these changes
Oct 30, 2023
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. I just made a minor coding style suggestion.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka
commented
Oct 30, 2023
MemberAuthor
Thank you Victor for your review. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 30, 2023
…GH-111455) Also document the behavior when called with NULL. (cherry picked from commit bca3305) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-111507 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka added a commit
that referenced
this pull request
Oct 30, 2023
FullteaR pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
…GH-111455) Also document the behavior when called with NULL.
aisk pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…GH-111455) Also document the behavior when called with NULL.
Glyphack pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…GH-111455) Also document the behavior when called with NULL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also document the behavior when called with NULL.
📚 Documentation preview 📚: https://cpython-previews--111455.org.readthedocs.build/