Skip to content

gh-111062: Reusable Windows build that supports free-threaded mode as the conditional CI - #111493

Merged
corona10 merged 8 commits into
python:mainfrom
corona10:gh-111062-windows
Oct 30, 2023
Merged

gh-111062: Reusable Windows build that supports free-threaded mode as the conditional CI#111493
corona10 merged 8 commits into
python:mainfrom
corona10:gh-111062-windows

Conversation

@corona10

@corona10corona10 commented Oct 30, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@ghost

ghost commented Oct 30, 2023•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-appbedevere-appBot mentioned this pull request Oct 30, 2023
Closed
@corona10

corona10 commented Oct 30, 2023

Copy link
Copy Markdown
MemberAuthor

co-work with @jota12x

corona10
corona10 commented Oct 30, 2023
View reviewed changes
Comment thread.github/workflows/reusable-build-win.yml

jobs:
build_win_32:
name: 'build and test (x86)'

@corona10corona10Oct 30, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk I would like to use the name as build and test variations for macOS and Linux too.
It looks more clear when we look at the CI status bar.
But I will do it as a separate PR.

@corona10corona10 reopened this Oct 30, 2023
@corona10

corona10 commented Oct 30, 2023

Copy link
Copy Markdown
MemberAuthor

Reopen the PR for testing topic-free-threaded label.

@hugovkhugovk changed the title gh-111062: Reusable windows build that supports free-threaded mode as the conditional CIgh-111062: Reusable Windows build that supports free-threaded mode as the conditional CIOct 30, 2023
@jota12x@corona10
pythongh-111062Set up free-threaded CI for windows
869a2f3
Co-authored-by: Donghee Na <donghee.na@python.org>
hugovk
hugovk reviewed Oct 30, 2023
View reviewed changes
Comment thread.github/workflows/reusable-build-win.yml
Comment thread.github/workflows/build.yml Outdated
Comment thread.github/workflows/build.yml Outdated
corona10and others added 3 commits October 30, 2023 23:35
@corona10@hugovk
Apply suggestions from code review
69f5ad8
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10
Update
d874a25
@corona10
Update names
5451d22
@corona10
corona10 requested a review from hugovkOctober 30, 2023 14:38
@corona10

corona10 commented Oct 30, 2023

Copy link
Copy Markdown
MemberAuthor

@hugovk For #110764, I merged the PR. Let's do it at the separate PR if there is something what we should do

@corona10
corona10 merged commit 4ebf2fa into python:mainOct 30, 2023
@corona10
corona10 deleted the gh-111062-windows branch October 30, 2023 15:30
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member

On a doc PR, the CI failed because Windows was skipped: https://github.com/python/cpython/actions/runs/6696696148/job/18198167333?pr=111512

It's surprising that once the job is called build_windows, but later build_win_amd64 is allowed to be skipped. Is it a typo?

cc @Eclips4

@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member

Ah, #111521 was proposed to fix the job.

FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@corona10@jota12x
@hugovk@FullteaR
pythongh-111062: Reusable Windows build that supports free-threaded m…
834e1f2
…ode as the conditional CI (python#111493)
* pythongh-111062 Set up free-threaded CI for windows
Co-authored-by: Donghee Na <donghee.na@python.org>
* Apply suggestions from code review
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
* Update
* Update names
* Add files
* Update
* Revert "Update"
This reverts commit 4f17e1a.
* fix
---------
Co-authored-by: juanjose.tenorio <juanjose2611@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10@jota12x
@hugovk@aisk
pythongh-111062: Reusable Windows build that supports free-threaded m…
5cfe748
…ode as the conditional CI (python#111493)
* pythongh-111062 Set up free-threaded CI for windows
Co-authored-by: Donghee Na <donghee.na@python.org>
* Apply suggestions from code review
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
* Update
* Update names
* Add files
* Update
* Revert "Update"
This reverts commit 4f17e1a.
* fix
---------
Co-authored-by: juanjose.tenorio <juanjose2611@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10@jota12x
@hugovk@Glyphack
pythongh-111062: Reusable Windows build that supports free-threaded m…
087af96
…ode as the conditional CI (python#111493)
* pythongh-111062 Set up free-threaded CI for windows
Co-authored-by: Donghee Na <donghee.na@python.org>
* Apply suggestions from code review
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
* Update
* Update names
* Add files
* Update
* Revert "Update"
This reverts commit 4f17e1a.
* fix
---------
Co-authored-by: juanjose.tenorio <juanjose2611@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

@hugovkhugovk

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@vstinner@hugovk@jota12x