Skip to content

gh-90815: Define WITH_MIMALLOC macro in PC/pyconfig.h - #111528

Closed
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:mimalloc_win
Closed

gh-90815: Define WITH_MIMALLOC macro in PC/pyconfig.h#111528
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:mimalloc_win

Conversation

@vstinner

@vstinnervstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member

@vstinner

Copy link
Copy Markdown
MemberAuthor

Example of a recent PR, test.pythoninfo of Windows x64 says:

build.WITH_MIMALLOC: No

@vstinner

Copy link
Copy Markdown
MemberAuthor

The build fails on Windows. Example:

obmalloc.obj : error LNK2005: _mi_free already defined in alloc.obj [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

cc @DinoV

@DinoV

Copy link
Copy Markdown
Contributor

The build fails on Windows. Example:

obmalloc.obj : error LNK2005: _mi_free already defined in alloc.obj [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

cc @DinoV

I think the issue here is that we're including the files in the Windows build but they're now included via obmalloc.c (this had changed along the way). I'll let the build bots see if #111532 fixes it.

@vstinner

Copy link
Copy Markdown
MemberAuthor

@DinoV wrote the correct fix: #111532

@vstinner
vstinner deleted the mimalloc_win branch October 31, 2023 19:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@DinoV