Skip to content

gh-110383: Explained which error message is generated when there is an unhandled exception - #111574

Merged
hugovk merged 3 commits into
python:mainfrom
Unique-Usman:unique_exception
Nov 19, 2023
Merged

gh-110383: Explained which error message is generated when there is an unhandled exception#111574
hugovk merged 3 commits into
python:mainfrom
Unique-Usman:unique_exception

Conversation

@Unique-Usman

@Unique-UsmanUnique-Usman commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

The line "with a message as shown above" is ambiguous as an error message has also came after the intended error message. So, I clealy explain which error message is generated and linked the message to where it is being described.


📚 Documentation preview 📚: https://cpython-previews--111574.org.readthedocs.build/

@bedevere-appbedevere-appBot mentioned this pull request Oct 31, 2023
@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Oct 31, 2023
@Unique-UsmanUnique-Usman changed the title gh-110383: Explained which error message is generated when there is an unhandled exception gh-110383: Explained which error message is generated when there is an unhandled exceptionOct 31, 2023
@Unique-Usman

Copy link
Copy Markdown
ContributorAuthor

@hugovk@CAM-Gerlach help review this.

@hugovk

Copy link
Copy Markdown
Member

Which one is this from the list at #110383?

@Unique-Usman

Copy link
Copy Markdown
ContributorAuthor

List of erata - 8

https://mail.python.org/archives/list/docs@python.org/thread/ZEDPZHRVGLYR4ZFZ5I3NBWVMHMX4WPGW/

Comment threadDoc/tutorial/errors.rst Outdated
@hugovkhugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 19, 2023
Explained what happened when there is no handler for an exception i.e unhandled exception.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk

Copy link
Copy Markdown
Member

Thank you!

@hugovk
hugovk merged commit a6d25de into python:mainNov 19, 2023
@miss-islington-app

Copy link
Copy Markdown

Thanks @Unique-Usman for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
…e is an unhandled exception (pythonGH-111574)
(cherry picked from commit a6d25de)
Co-authored-by: Unique-Usman <86585626+Unique-Usman@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
…e is an unhandled exception (pythonGH-111574)
(cherry picked from commit a6d25de)
Co-authored-by: Unique-Usman <86585626+Unique-Usman@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app

Copy link
Copy Markdown

GH-112264 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 19, 2023
@bedevere-app

Copy link
Copy Markdown

GH-112265 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Nov 19, 2023
@Unique-Usman

Copy link
Copy Markdown
ContributorAuthor

It makes sense like this, as it has been clearly mentioned that it is an unhandled exception. Thank you @hugovk

hugovk added a commit that referenced this pull request Nov 19, 2023
…re is an unhandled exception (GH-111574) (#112264)
Co-authored-by: Unique-Usman <86585626+Unique-Usman@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Nov 19, 2023
…re is an unhandled exception (GH-111574) (#112265)
Co-authored-by: Unique-Usman <86585626+Unique-Usman@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@Unique-Usman
Unique-Usman deleted the unique_exception branch November 19, 2023 15:51
@Unique-Usman
Unique-Usman restored the unique_exception branch November 19, 2023 15:51
@Unique-Usman
Unique-Usman deleted the unique_exception branch November 19, 2023 15:51
@Unique-Usman
Unique-Usman restored the unique_exception branch November 19, 2023 15:51
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…e is an unhandled exception (python#111574)
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…e is an unhandled exception (python#111574)
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Unique-Usman@hugovk