Skip to content

gh-111495: add stub files for C API test modules - #111586

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
skirpichev:add-stubs-for-capi-tests
Nov 1, 2023
Merged

gh-111495: add stub files for C API test modules#111586
serhiy-storchaka merged 5 commits into
python:mainfrom
skirpichev:add-stubs-for-capi-tests

Conversation

@skirpichev

@skirpichevskirpichev commented Nov 1, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

@skirpichev
pythongh-111495: add stub files for C API test modules
d8fa0b0
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
@bedevere-appbedevere-appBot mentioned this pull request Nov 1, 2023
Closed
10 tasks
@skirpichev

skirpichev commented Nov 1, 2023

Copy link
Copy Markdown
MemberAuthor

So far there is only files from #111496, #111562 and #109647. More is coming.

CC @serhiy-storchaka

@skirpichev
skirpichev marked this pull request as ready for review November 1, 2023 02:39
@skirpichev
skirpichev requested a review from a team as a code ownerNovember 1, 2023 02:39
@skirpichev

skirpichev commented Nov 1, 2023

Copy link
Copy Markdown
MemberAuthor

Ok, all test modules for #111495 were added. @serhiy-storchaka, this is ready for review.

BTW, perhaps this should be labeled "tests" automatically?

@skirpichevskirpichev mentioned this pull request Nov 1, 2023
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Nov 1, 2023
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to remove parameter names in declarations, but LGTM.

@serhiy-storchakaserhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.12 only security fixes skip news labels Nov 1, 2023
@serhiy-storchaka

serhiy-storchaka commented Nov 1, 2023

Copy link
Copy Markdown
Member

It could be an opportunity to re-order all lists in alphabetic order, but it would make more difficult to see what items were added.

@serhiy-storchaka
serhiy-storchaka merged commit 33ed5fa into python:mainNov 1, 2023
@miss-islington-app

miss-islington-appBot commented Nov 1, 2023

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 1, 2023

Copy link
Copy Markdown

Sorry, @skirpichev and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33ed5fa69dbe25d64a910c450be527f4db9dc5dd 3.12

@serhiy-storchaka

serhiy-storchaka commented Nov 1, 2023

Copy link
Copy Markdown
Member

I guess some changes were not backported to 3.12. @skirpichev could you please manually create a backport?

@skirpichev

skirpichev commented Nov 1, 2023 via email

Copy link
Copy Markdown
MemberAuthor

@skirpichev
skirpichev deleted the add-stubs-for-capi-tests branch November 1, 2023 06:03
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 1, 2023
@skirpichev
[3.12]pythongh-111495: add stub files for C API test modules (python…
2b9c6d3
…GH-111586)
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
(cherry picked from commit 33ed5fa)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app

bedevere-appBot commented Nov 1, 2023

Copy link
Copy Markdown

GH-111592 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 1, 2023
serhiy-storchaka pushed a commit that referenced this pull request Nov 1, 2023
@skirpichev
[3.12]gh-111495: add stub files for C API test modules (GH-111586) (G…
9619e51
…H-111592)
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
(cherry picked from commit 33ed5fa)
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@skirpichev@FullteaR
pythongh-111495: add stub files for C API test modules (pythonGH-111586)
ee9552c
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@skirpichev@aisk
pythongh-111495: add stub files for C API test modules (pythonGH-111586)
0949c16
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@skirpichev@Glyphack
pythongh-111495: add stub files for C API test modules (pythonGH-111586)
081d606
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
@serhiy-storchakaserhiy-storchaka removed their assignment Jul 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev@serhiy-storchaka