Skip to content

gh-111615: Fix regression in QueueHandler configuration. - #111638

Merged
vsajip merged 1 commit into
python:mainfrom
vsajip:fix-111615
Dec 27, 2023
Merged

gh-111615: Fix regression in QueueHandler configuration.#111638
vsajip merged 1 commit into
python:mainfrom
vsajip:fix-111615

Conversation

@vsajip

@vsajipvsajip commented Nov 2, 2023

Copy link
Copy Markdown
Member

@vsajipvsajip added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 3.12 only security fixes 3.13 bugs and security fixes labels Nov 2, 2023
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vsajip for commit 7d19184 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@vsajip

Copy link
Copy Markdown
MemberAuthor

Buildbot failures seem to be either Python build issues, or unrelated failures in test.test_asyncio.test_streams.

@vsajip
vsajip merged commit 67655d8 into python:mainDec 27, 2023
@vsajip
vsajip deleted the fix-111615 branch December 27, 2023 09:35
@vsajipvsajip added the needs backport to 3.12 only security fixes label Dec 27, 2023
@miss-islington-app

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app

Copy link
Copy Markdown

GH-113507 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 27, 2023
…nGH-111638)
(cherry picked from commit 67655d8)
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Dec 27, 2023
@brettcannon

Copy link
Copy Markdown
Member

This broke the WASI builds as multiprocessing isn't available. Opened #113692 to track the breakage.

https://buildbot.python.org/all/#/builders/1046/builds/3844

======================================================================
ERROR: test_111615 (test.test_logging.ConfigDictTest.test_111615)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Lib/test/test_logging.py", line 3934, in test_111615
'queue': mp.get_context('spawn').Queue(),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Lib/multiprocessing/context.py", line 102, in Queue
from .queues import Queue
File "/Lib/multiprocessing/queues.py", line 23, in <module>
import _multiprocessing
ModuleNotFoundError: No module named '_multiprocessing'
----------------------------------------------------------------------

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.12only security fixes3.13bugs and security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vsajip@bedevere-bot@brettcannon